Skip to content

Namespace S3 throws InternalError on some flows #9891

Description

@romayalon

Environment info

  • NooBaa Version: 4.23
  • Platform: ODF

Actual behavior

  1. Currently, on most of the functions of NamespaceS3 we don't call translate_error_code(), therefore we don't throw the error with rpc_code, which causes us to not translate correctly errors and we will fallback to InternalError. For example - call upload-part, list-parts, complete, and abort with a non existing upload ID will result with InternalError instead of NoSuchUpload. This is one example but the whole file completely should map errors correctly.

Expected behavior

  1. throw an informative error code instead of InternalError.

Steps to reproduce

1. create a namespace bucket on top of Namespace resource pointing to an s3 endpoint and bucket.
2. create an alias with s3api client pointing to noobaa endpoint and has access to the namespace bucket from bullet 1.
3. s3api list-multiparts --bucket ns.bucket --key upload1 --upload-id=<non-existing-upload-id>
4. s3api abort-upload --bucket ns.bucket --key upload1 --upload-id=<non-existing-upload-id>
5. s3api upload-part --bucket ns.bucket --key upload1 --upload-id=<non-existing-upload-id>

More information - Screenshots / Logs / Other output

s.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions