Skip to content

Commit 4422830

Browse files
authored
Merge branch 'noodanee:master' into master
2 parents 68ed824 + ac563a6 commit 4422830

2 files changed

Lines changed: 48 additions & 3 deletions

File tree

.coderabbit.yaml

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,42 @@
1+
language: "zh-CN"
2+
early_access: false
3+
reviews:
4+
profile: "chill"
5+
request_changes_workflow: false
6+
high_level_summary: true
7+
poem: false
8+
review_status: true
9+
collapse_walkthrough: false
10+
auto_review:
11+
enabled: true
12+
drafts: false
13+
base_branches:
14+
- master
15+
path_instructions:
16+
- path: "lib/**/*.cpp"
17+
instructions: |
18+
Review C++ native addon code for:
19+
- Memory safety and RAII patterns
20+
- Thread safety with proper mutex usage
21+
- N-API best practices
22+
- Exception handling in destructors
23+
- path: "lib/**/*.h"
24+
instructions: |
25+
Review C++ headers for:
26+
- Proper include guards
27+
- Forward declarations where possible
28+
- Clean public/private separation
29+
- path: "src/**/*.ts"
30+
instructions: |
31+
Review TypeScript code for:
32+
- Type safety and proper typing
33+
- Async/await patterns
34+
- Error handling
35+
- path: "test/**/*.ts"
36+
instructions: |
37+
Review tests for:
38+
- Test coverage completeness
39+
- Mock usage correctness
40+
- Edge case handling
41+
chat:
42+
auto_reply: true

.github/workflows/build.yml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -187,16 +187,19 @@ jobs:
187187

188188
linux-musl-arm64:
189189
runs-on: ubuntu-24.04-arm
190-
container:
191-
image: alpine:latest
192190
env:
193191
ZIG_TARGET: aarch64-linux-musl
194192
steps:
195193
- name: Checkout
196194
uses: actions/checkout@v4
197195

196+
- name: Setup Node.js
197+
uses: actions/setup-node@v4
198+
with:
199+
node-version: 18
200+
198201
- name: Install system dependencies
199-
run: apk add --no-cache nodejs npm bash build-base cmake ninja python3 curl unzip git autoconf automake libtool pkgconfig
202+
run: sudo apt-get update && sudo apt-get install -y build-essential cmake ninja-build python3 curl unzip git autoconf automake libtool pkg-config
200203

201204
- name: Setup Zig
202205
uses: mlugg/setup-zig@v2

0 commit comments

Comments
 (0)