Skip to content

Commit a9ea6ec

Browse files
authored
Fix reversed primary interactive colors in light/dark modes (#759)
* fix(colors): correct reversed primary interactive colors between light and dark modes The primary interactive colors (primary, primaryHover, primaryActive) were incorrectly swapped between light and dark modes. Light mode was using dark blue colors while dark mode was using light grey colors, causing visibility and contrast issues. Changes: - Light mode: now uses grey.grey500/600/700 for primary states - Dark mode: now uses darkBlue.darkBlue500/700/800 for primary states - Fixed linkInverse in dark mode to use deepBlue500 instead of deepBlue200 * chore(package.json): bump version from 11.2.2 to 11.2.3 for patch release
1 parent 3996c8e commit a9ea6ec

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "@nordcloud/gnui",
33
"description": "Nordcloud Design System - a collection of reusable React components used in Nordcloud's SaaS products",
4-
"version": "11.2.2",
4+
"version": "11.2.3",
55
"license": "MIT",
66
"repository": {
77
"type": "git",

src/theme/dark.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,14 +32,14 @@ const DARK_COLORS = [
3232
["--border-info", palette.blue.blue300],
3333
["--border-warning", palette.orange.orange300],
3434
["--border-discovery", palette.grey.grey400],
35-
["--interactive-primary", palette.grey.grey500],
36-
["--interactive-primaryHover", palette.grey.grey600],
37-
["--interactive-primaryActive", palette.grey.grey700],
35+
["--interactive-primary", palette.darkBlue.darkBlue500],
36+
["--interactive-primaryHover", palette.darkBlue.darkBlue700],
37+
["--interactive-primaryActive", palette.darkBlue.darkBlue800],
3838
["--interactive-secondary", palette.darkGrey.darkGrey400],
3939
["--interactive-secondaryHover", palette.darkGrey.darkGrey500],
4040
["--interactive-secondaryActive", palette.darkGrey.darkGrey600],
4141
["--interactive-link", palette.deepBlue.deepBlue200],
42-
["--interactive-linkInverse", palette.deepBlue.deepBlue200],
42+
["--interactive-linkInverse", palette.deepBlue.deepBlue500],
4343
["--interactive-error", palette.red.red400],
4444
["--interactive-errorHover", palette.red.red500],
4545
["--interactive-errorActive", palette.red.red600],

src/theme/light.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -32,9 +32,9 @@ const LIGHT_COLORS = [
3232
["--border-info", palette.blue.blue700],
3333
["--border-warning", palette.orange.orange700],
3434
["--border-discovery", palette.grey.grey700],
35-
["--interactive-primary", palette.darkBlue.darkBlue500],
36-
["--interactive-primaryHover", palette.darkBlue.darkBlue700],
37-
["--interactive-primaryActive", palette.darkBlue.darkBlue800],
35+
["--interactive-primary", palette.grey.grey500],
36+
["--interactive-primaryHover", palette.grey.grey600],
37+
["--interactive-primaryActive", palette.grey.grey700],
3838
["--interactive-secondary", palette.grey.grey300],
3939
["--interactive-secondaryHover", palette.grey.grey400],
4040
["--interactive-secondaryActive", palette.grey.grey500],

0 commit comments

Comments
 (0)