Fix book recipe list (#205)

* fix book recipe list

* add read_skill to books

* add read_skill to books

Author: esphas

src/types.ts

@@ -310,6 +310,7 @@ export type BookSlot = {
   time?: number /* mins */ | string /* duration */;
 
   skill?: string; // skill_id
+  read_skill?: string; // skill_id
   martial_art?: string; // matype_id
   chapters?: number; // default: 0
   proficiencies?: BookProficiencyBonus[];

src/types/Skill.svelte

@@ -20,7 +20,10 @@ const data = getContext<CddaData>("data");
 
 const booksWithSkill = data
   .byType("item")
-  .filter((t) => t.id && isItemSubtype("BOOK", t) && t.skill === item.id)
+  .filter(
+    (t) =>
+      t.id && isItemSubtype("BOOK", t) && (t.read_skill ?? t.skill) === item.id
+  )
   .sort((a, b) =>
     singularName(a).localeCompare(singularName(b))
   ) as SupportedTypesWithMapped["BOOK"][];

src/types/item/BookInfo.svelte

@@ -19,23 +19,27 @@ function add(recipe_id: string, level: number) {
   );
 }
 for (const recipe of data.byType("recipe")) {
-  if (recipe.result && Array.isArray(recipe.book_learn))
+  if (!recipe.result) continue;
+  if (Array.isArray(recipe.book_learn)) {
     for (const [id, level = 0] of recipe.book_learn)
       if (id === item.id) add(recipe.result, level);
-      else if (recipe.book_learn)
-        for (const [id, obj] of Object.entries(
-          recipe.book_learn as Record<string, any>
-        ))
-          if (id === item.id) add(recipe.result, obj.skill_level ?? 0);
+  } else if (recipe.book_learn) {
+    for (const [id, obj] of Object.entries(
+      recipe.book_learn as Record<string, any>
+    ))
+      if (id === item.id) add(recipe.result, obj.skill_level ?? 0);
+  }
 }
+
+const readSkill = item.read_skill ?? item.skill;
 </script>
 
 <section>
   <h1>{t("Book", { _context, _comment: "Section heading" })}</h1>
   <dl>
-    {#if item.skill}
+    {#if readSkill}
       <dt>{t("Skill", { _context })}</dt>
-      <dd><ThingLink id={item.skill} type="skill" /></dd>
+      <dd><ThingLink id={readSkill} type="skill" /></dd>
       <dt>{t("Required Level", { _context })}</dt>
       <dd>{item.required_level ?? 0}</dd>
       <dt>{t("Maximum Level", { _context })}</dt>