Skip to content
This repository was archived by the owner on Oct 20, 2023. It is now read-only.

Commit 191360d

Browse files
authored
Merge pull request #2 from northwesternmutual/transcribe
fix: security fix
2 parents 4cf4e6c + b75c807 commit 191360d

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ AndroidManifest.xml
4848
<uses-permission android:name="android.permission.RECORD_AUDIO" />
4949
```
5050

51-
TODO Special settings for mic on android (adb emu avd hostmicon)
51+
Note: Special settings for mic on android (adb emu avd hostmicon)
5252
emulator -avd Pixel_3a_API_30_x86 -qemu -allow-host-audio
5353
https://developer.android.com/studio/run/emulator-commandline
5454
https://gist.github.com/wswebcreation/80f5536ab1592aff0c25a9dbd9cc1451

android/src/main/java/com/reactnativetranscribe/TranscribeModule.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ public class TranscribeModule extends ReactContextBaseJavaModule {
3232
private AudioRecord audioRecord;
3333
private boolean isRecording;
3434

35-
//TODO ADD AS OPTIONS
3635
int audioSource = MediaRecorder.AudioSource.MIC;
3736
int sampleRateInHz = 8000;
3837
int channelConfig = AudioFormat.CHANNEL_IN_MONO;
@@ -79,7 +78,7 @@ private boolean isPermissionGranted() {
7978
Log.d(TAG,"isPermissionsGranted");
8079

8180
String permission = Manifest.permission.RECORD_AUDIO;
82-
int res = getReactApplicationContext().checkCallingOrSelfPermission(permission);
81+
int res = getReactApplicationContext().checkCallingPermission(permission);
8382
return res == PackageManager.PERMISSION_GRANTED;
8483
}
8584

0 commit comments

Comments
 (0)