fixes(#1002): Schedule deferred drop for render passes to avoid dropping before frame is over#1003
Merged
Merged
Conversation
Contributor
|
I think this looks reasonable to me and it way more closely matches the behaviour people probably expect, though I obviously can't merge it, that's still a @not-fl3 job 👀 |
Owner
|
Sure sure @profan :D Thanks for PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates render passes to be dropped in a similar manner as textures. When there are no more references to a render pass (other than itself), we schedule it for deletion that way we're not deleting textures before we use them. This way we guarantee that every render pass/render target will live until the end of the current frame.
Fixes issue #1002