Fix world_to_screen to handle viewport correctly#1017
Merged
Conversation
The screen_to_world method correctly accounts for viewport position and size, but world_to_screen was always mapping to full screen coordinates, ignoring any viewport setting. This made the two methods non-symmetric when a viewport was set. This fix adds the same viewport handling to world_to_screen that screen_to_world already has, making them proper inverses of each other.
Owner
|
Thanks for PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
screen_to_worldcorrectly accounts for viewport position and size, butworld_to_screenalways maps to full screen coordinates, ignoring any viewport setting. This makes the two methods non-symmetric when a viewport is set.Solution
Added the same viewport handling to
world_to_screenthatscreen_to_worldalready has, making them proper inverses of each other.Testing
Tested with a Camera2D using a viewport with margins (not at origin). Labels positioned using
world_to_screennow correctly appear within the viewport region and track world objects properly during pan/zoom.