Only call glFlush/glFinish if telemetry is enabled (fixes #275)#1043
Merged
Conversation
Owner
|
Thanks for PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #275
I also have linux with nvidia and for all macroquad programs I get ~96% CPU unless I put sleeps (which shouldn't be done inside async).
After the research done by the people in the issue and me, it seems to me that glFinish is not really needed, so this PR only keeps it if telemetry is enabled. I also made a getter for
telemetry::is_enabled().Here is a CPU usage comparison of the "basic_shapes" example:
I also tried this in wasm for my game and it seems to work with lowish CPU, but I didn't make a comparison so I don't know if before it was the same or higher.
Let me know if you want different format or different comments. Also it's ok if you don't want to merge, I did my own fork to try out other stuff.