fix: remove generate-envelope plugin support for blob signing #546
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junjie Gao <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #546 +/- ##
==========================================
+ Coverage 81.36% 81.47% +0.10%
==========================================
Files 36 36
Lines 3360 3358 -2
==========================================
+ Hits 2734 2736 +2
+ Misses 483 480 -3
+ Partials 143 142 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Junjie Gao <[email protected]>
Signed-off-by: Junjie Gao <[email protected]>
…th_generate_envelope
Signed-off-by: Junjie Gao <[email protected]>
JeyJeyGao
requested review from
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT and
toddysm
as code owners
There was a problem hiding this comment.
Pull Request Overview
This PR removes support for generating an envelope via plugins during blob signing, enforcing the use of the signature generator capability instead.
- Added a new test case to validate the failure when using a plugin with envelope capability for blob signing.
- Updated the blob signing logic in PluginSigner to only support signature generation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| signer/plugin_test.go | Added TestPluginSigner_SignBlob_Invalid to check correct error handling for improper capability. |
| signer/plugin.go | Removed the envelope generator branch and added a capability check that returns an error if the plugin lacks signature generator support. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #544