Fix Dataset.upload typo

evilkermit · evilkermit · commit 33c7b2cd2146 · 2026-03-12T10:52:11.000-04:00
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,8 @@
 ## Nova Galaxy 0.12.0 (in progress)
 
+### Nova Galaxy 0.11.7
+- Fixes an issue where calling `Dataset.download` after calling `Dataset.upload` on a remote file would result in an error (thanks to John Duggan). [Pull request x](x)
+
 ### Nova Galaxy 0.11.6
 - Fixes an issue where `get_url` could hang indefinitely when checking interactive tool URLs (thanks to John Duggan). [Pull request 62](https://github.com/nova-model/nova-galaxy-pull/62)
 
diff --git a/src/nova/galaxy/dataset.py b/src/nova/galaxy/dataset.py
@@ -96,7 +96,7 @@ def upload(self, store: "Datastore", name: Optional[str] = None) -> None:
                 history_id=store.history_id, tool_id=LOAD_NEUTRON_DATA_TOOL, tool_inputs=tool_inputs
             )
             self.id = results["outputs"][0]["id"]
-            self.store = self.store
+            self.store = store
 
         else:
             file_name = name if name else self.name

Original file line number	Diff line number	Diff line change
`@@ -96,7 +96,7 @@ def upload(self, store: "Datastore", name: Optional[str] = None) -> None:`
`96`	`96`	`history_id=store.history_id, tool_id=LOAD_NEUTRON_DATA_TOOL, tool_inputs=tool_inputs`
`97`	`97`	`)`
`98`	`98`	`self.id = results["outputs"][0]["id"]`
`99`		`- self.store = self.store`
	`99`	`+ self.store = store`
`100`	`100`
`101`	`101`	`else:`
`102`	`102`	`file_name = name if name else self.name`