feat: use arizona_nova_live:live/1 for --arizona routes (no controller or copy script needed)

Taure · Taure · commit 8b6a8bea01a4 · 2026-03-19T23:18:20.000+01:00
diff --git a/src/rebar3_nova_new.erl b/src/rebar3_nova_new.erl
@@ -618,10 +618,11 @@ generate_router(Name, #{arizona := true}) ->
         "            prefix => \"\",\n",
         "            security => false,\n",
         "            routes => [\n",
-        "                {\"/\", fun ",
+        "                {\"/\", arizona_nova_live:live(",
         Name,
-        "_main_controller:index/1, #{methods => [get]}},\n",
+        "_home_view), #{methods => [get]}},\n",
         "                {\"/heartbeat\", fun(_) -> {status, 200} end, #{methods => [get]}},\n",
+        "                {\"/live\", arizona_nova_websocket, #{protocol => ws}},\n",
         "                {\"/assets/[...]\", \"static/assets\"}\n",
         "            ]\n",
         "        }\n",
@@ -669,38 +670,9 @@ generate_controller(Name, #{lfe := true}) ->
         "    `#(status 200 #M() \"nova is running!\"))\n"
     ],
     rebar3_nova_utils:write_file(Path, Content);
-generate_controller(Name, #{arizona := true}) ->
-    Path = filename:join([Name, "src", "controllers", Name ++ "_main_controller.erl"]),
-    Content = [
-        "-module(",
-        Name,
-        "_main_controller).\n\n",
-        "-export([index/1]).\n\n",
-        "index(_Req) ->\n",
-        "    Html = <<\"<!DOCTYPE html>\"\n",
-        "            \"<html lang=\\\"en\\\">\"\n",
-        "            \"<head>\"\n",
-        "            \"<meta charset=\\\"UTF-8\\\">\"\n",
-        "            \"<meta name=\\\"viewport\\\" content=\\\"width=device-width, initial-scale=1.0\\\">\"\n",
-        "            \"<title>",
-        Name,
-        "</title>\"\n",
-        "            \"<link rel=\\\"stylesheet\\\" href=\\\"/assets/app.css\\\">\"\n",
-        "            \"</head>\"\n",
-        "            \"<body>\"\n",
-        "            \"<div id=\\\"app\\\"><h1>Welcome to ",
-        Name,
-        "</h1>\"\n",
-        "            \"<p>Powered by Nova + Arizona</p></div>\"\n",
-        "            \"<script type=\\\"module\\\">\"\n",
-        "            \"import Arizona from '/assets/js/arizona.min.js';\"\n",
-        "            \"globalThis.arizona = new Arizona();\"\n",
-        "            \"arizona.connect('/live');\"\n",
-        "            \"</script>\"\n",
-        "            \"</body></html>\">>,\n",
-        "    {status, 200, #{<<\"content-type\">> => <<\"text/html\">>}, Html}.\n"
-    ],
-    rebar3_nova_utils:write_file(Path, Content);
+generate_controller(_Name, #{arizona := true}) ->
+    %% No controller needed — arizona_nova_live:live/1 handles rendering
+    ok;
 generate_controller(Name, _Flags) ->
     Path = filename:join([Name, "src", "controllers", Name ++ "_main_controller.erl"]),
     Content = [
@@ -1134,8 +1106,7 @@ generate_docker_compose(Name) ->
 
 maybe_generate_arizona(Name, #{arizona := true}) ->
     generate_home_view(Name),
-    generate_app_css(Name),
-    generate_arizona_copy_script(Name);
+    generate_app_css(Name);
 maybe_generate_arizona(_Name, _Flags) ->
     ok.
 
@@ -1214,20 +1185,6 @@ generate_app_css(Name) ->
     ],
     rebar3_nova_utils:write_file(Path, Content).
 
-generate_arizona_copy_script(Name) ->
-    Path = filename:join([Name, "copy_arizona_assets.sh"]),
-    Content = [
-        "#!/bin/sh\n",
-        "# Copy Arizona JS assets from arizona_core dep to app priv\n",
-        "SRC=_build/default/lib/arizona_core/priv/static/assets/js\n",
-        "DEST=priv/static/assets/js\n",
-        "mkdir -p \"$DEST\"\n",
-        "cp \"$SRC/arizona.min.js\" \"$DEST/arizona.min.js\"\n",
-        "echo \"Copied Arizona JS to $DEST\"\n"
-    ],
-    rebar3_nova_utils:write_file(Path, Content),
-    file:change_mode(Path, 8#755).
-
 %%======================================================================
 %% maybe_generate_ci
 %%======================================================================
@@ -1302,11 +1259,4 @@ print_summary(Name, Flags) ->
         false ->
             ok
     end,
-    case maps:get(arizona, Flags) of
-        true ->
-            rebar_api:info("  rebar3 compile~n", []),
-            rebar_api:info("  ./copy_arizona_assets.sh~n", []);
-        false ->
-            ok
-    end,
     rebar_api:info("  rebar3 nova serve~n", []).
diff --git a/test/rebar3_nova_new_SUITE.erl b/test/rebar3_nova_new_SUITE.erl
@@ -154,7 +154,8 @@ arizona_flag(_Config) ->
     assert_not_contains(RebarConfig, "erlydtl"),
 
     Router = read_file(Name, "src/testapp_arizona_router.erl"),
-    assert_contains(Router, "_main_controller:index/1"),
+    assert_contains(Router, "arizona_nova_live:live("),
+    assert_contains(Router, "arizona_nova_websocket"),
 
     DevConfig = read_file(Name, "config/dev_sys.config.src"),
     assert_contains(DevConfig, "arizona_core"),
@@ -251,7 +252,7 @@ combined_kura_arizona_ci(_Config) ->
     assert_not_contains(RebarConfig, "erlydtl"),
 
     Router = read_file(Name, "src/testapp_combo_router.erl"),
-    assert_contains(Router, "_main_controller:index/1"),
+    assert_contains(Router, "arizona_nova_live:live("),
 
     SupErl = read_file(Name, "src/testapp_combo_sup.erl"),
     assert_contains(SupErl, "supervisor"),
