Several Issues noted in VT100.js #6
Description
These comments apply to VT100.js
Several Attributes are not correctly processed in the SGR code:
Ps 5 - Blink
Ps 7 - Inverse.
Ps 39/39 - Default attribute FG/BG.
State Machine
The whole state machine becomes a LOT simpler with a generator and makes correcting the sequences like "Esc (" easier. This is followed by a character and you would need another state to drop this ( not dropped now). The same is true for ESC "%#" etc. Trivial to implement and cleans up state handling.
The state machine appears to process characters before checking the escape state. While none of these should appear in an escape sequence, this is not correct.
Report Back Sequences
Device Status Report ( DSR) is not implemented and unless the code is split into a stream handler and a screen handler any report back code is not very clean.
Key Interpretation
No function keys are implemented.
'\n' needs to be passed to addch() or cursor handling is off.