Compatibility with .NET 10 TFMs

[kevinchalet]

Hey @clairernovotny,

Hope you're doing well after all these years 😃

I'm currently updating OpenIddict to use the .NET 10 RC2 SDK and I'm seeing a few issues that seem to be directly related to my use of MSBuildSdkExtras: for some reasons, adding the net10.0 TFM in a SDK-style project that relies on MSBuild.Sdk.Extras/3.0.44 completely prevents the project from building correctly.

I'm able to reproduce this issue very easily by simply updating this ultra-minimal .NET 9.0 .csproj:

<Project Sdk="MSBuild.Sdk.Extras/3.0.44">

  <PropertyGroup>
    <TargetFramework>net9.0</TargetFramework>
  </PropertyGroup>

</Project>

... to .NET 10.0:

<Project Sdk="MSBuild.Sdk.Extras/3.0.44">

  <PropertyGroup>
    <TargetFramework>net10.0</TargetFramework> 
  </PropertyGroup>

</Project>

While the version that targets .NET 9.0 builds just fine, the one that targets .NET 10.0 doesn't. For some reasons, net10.0 is recognized as .NET Framework when MSBuild.Sdk.Extras/3.0.44 is used:

MSB3971: The reference assemblies for ".NETFramework,Version=v10.0" were not found. You might be using an older .NET SDK to target .NET 5.0 or higher. Update Visual Studio and/or your .NET SDK.

Could it be something as trivial as the two-digit version used in .NET 10.0 not being recognized by MSBuildSdkExtras?

All the best.

[kevinchalet]

I believe the problem is right here:

MSBuildSdkExtras/Source/MSBuild.Sdk.Extras/Build/Inference.targets

Line 55 in b58e1d2

<TargetFrameworkIdentifier Condition="'$(_SdkShortFrameworkIdentifier)' == 'netcoreapp' OR ('$(_SdkShortFrameworkIdentifier)' == 'net' AND $(_SdkShortFrameworkVersion[0]) >= 5)">.NETCoreApp</TargetFrameworkIdentifier>

That check only uses the first digit of the extracted version to determine whether the target framework might be a .NET (Core) TFM, but since 1 < 5, the TargetFrameworkIdentifier property is never correctly set for net10.0 (and higher... at least up to .NET <50 🤣 ).

I was able to work around that bug by explicitly setting TargetFrameworkIdentifier to .NETCoreApp when the TFM is a .NET (Core) TFM:

<PropertyGroup>
  <TargetFrameworks>...</TargetFrameworks>
  <TargetFrameworkIdentifier Condition=" $([MSBuild]::GetTargetFrameworkIdentifier('$(TargetFramework)')) == '.NETCoreApp' ">.NETCoreApp</TargetFrameworkIdentifier>
</PropertyGroup>

[mfkl]

Interested in this fix as well, let me know if I can help.

[mitchcapper]

the PR doesn't work but the <TargetFrameworkIdentifier Condition=" $([MSBuild]::GetTargetFrameworkIdentifier('$(TargetFramework)')) == '.NETCoreApp' ">.NETCoreApp</TargetFrameworkIdentifier> addition to the project does for me.