upgrade: refit 8.0 with microsoft dependencies >=8.x #96 (#101)

toddb · todd · web-flow · commit 6f64ca130779 · 2025-02-18T07:07:36.000+05:30
Co-authored-by: todd &lt;todd+github@goneopen.com&gt;
diff --git a/README.md b/README.md
@@ -39,6 +39,8 @@ novu-dotnet targets .NET Standard 2.0 and is compatible with .NET Core 2.0+ and
 | 0.3.2       | \>= 0.18                                                                     | [BREAKING} Obsolete Notification Templates has been removed. Service registration separation of single client and each client. Novu.Extension and Novu.Sync released as packages.                                                       |
 | 0.3.2       | \>= 0.18                                                                     |                                                                                                                                                                                                                                         |
 | 0.4.0       | \>= 0.24                                                                     |                                                                                                                                                                                                                                         |
+| 0.5.0       | \>= 0.24                                                                     | Refit 7.2.2 / Microsoft.Extension>=7.x                                                                                                                                                                                                  |
+| 0.6.0       | \>= 0.24                                                                     | Refit 8.0 / Microsoft.Extension>=8.x                                                                                                                                                                                                    |
 
 ## Installation
 
@@ -51,8 +53,7 @@ dotnet add package Novu
 ### Direct instantiation
 
 ```csharp
-using Novu.DTO;
-using Novu.Models;
+using Novu.Domain.Models;
 using Novu;
 
  var novuConfiguration = new NovuClientConfiguration
diff --git a/src/Novu.Extensions/Novu.Extensions.csproj b/src/Novu.Extensions/Novu.Extensions.csproj
@@ -21,15 +21,15 @@
 
     <ItemGroup>
         <PackageReference Include="JetBrains.Annotations" Version="2024.3.0" />
-        <PackageReference Include="Microsoft.Extensions.Configuration" Version="7.0.0"/>
-        <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="7.0.4"/>
-        <PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="7.0.0"/>
-        <PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="7.0.0"/>
+        <PackageReference Include="Microsoft.Extensions.Configuration" Version="8.0.0" />
+        <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="8.0.2" />
+        <PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="8.0.0" />
+        <PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="8.0.1" />
         <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="7.0.0"/>
-        <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0"/>
-        <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="7.0.0" />
-        <PackageReference Include="Refit.HttpClientFactory" Version="7.2.22" />
-        <PackageReference Include="System.Configuration.ConfigurationManager" Version="7.0.0" />
+        <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.2"/>
+        <PackageReference Include="Microsoft.Extensions.Hosting.Abstractions" Version="8.0.1" />
+        <PackageReference Include="Refit.HttpClientFactory" Version="8.0.0" />
+        <PackageReference Include="System.Configuration.ConfigurationManager" Version="8.0.1" />
     </ItemGroup>
 
     <ItemGroup>
diff --git a/src/Novu.Sync/Novu.Sync.csproj b/src/Novu.Sync/Novu.Sync.csproj
@@ -25,7 +25,7 @@
     <ItemGroup>
         <!-- provides the hascode -->
         <PackageReference Include="Microsoft.Bcl.HashCode" Version="6.0.0" />
-        <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="7.0.0"/>
+        <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.2" />
     </ItemGroup>
 
     <!-- Nuget Assets -->
diff --git a/src/Novu.Tests/IntegrationTests/SubscriberPreferenceTests.cs b/src/Novu.Tests/IntegrationTests/SubscriberPreferenceTests.cs
@@ -86,7 +86,7 @@ public async Task Should_Get_InApp_Unseen()
         var messagesCount = await subscriberClient.GetInAppUnseen(subscriber.SubscriberId!);
 
         // fire forget test, that it returns something
-        messagesCount.Data.Count.Should().BeGreaterOrEqualTo(0);
+        messagesCount.Data.Count.Should().BeGreaterThanOrEqualTo(0);
     }
 
     [Fact]
@@ -97,6 +97,6 @@ public async Task Should_Get_InApp()
         var messages = await subscriberClient.GetInApp(subscriber.SubscriberId!);
 
         // fire forget test, that it returns something
-        messages.Data.Should().HaveCountGreaterOrEqualTo(0);
+        messages.Data.Should().HaveCountGreaterThanOrEqualTo(0);
     }
 }
diff --git a/src/Novu.Tests/Novu.Tests.csproj b/src/Novu.Tests/Novu.Tests.csproj
@@ -9,25 +9,25 @@
 
     <ItemGroup>
         <PackageReference Include="Microsoft.Extensions.Configuration.Abstractions" Version="8.0.0"/>
-        <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="8.0.0"/>
-        <PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="7.0.0"/>
-        <PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="7.0.0"/>
-        <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="7.0.0"/>
-        <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.0"/>
+        <PackageReference Include="Microsoft.Extensions.Configuration.Binder" Version="8.0.2" />
+        <PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="8.0.0" />
+        <PackageReference Include="Microsoft.Extensions.Configuration.FileExtensions" Version="8.0.1" />
+        <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="8.0.1"/>
+        <PackageReference Include="Microsoft.Extensions.DependencyInjection" Version="8.0.1" />
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.12.0" />
         <PackageReference Include="Moq" Version="4.20.72" />
         <PackageReference Include="ParkSquare.Testing.Helpers" Version="8.0.0" />
-        <PackageReference Include="Polly" Version="8.5.0" />
-        <PackageReference Include="Refit.HttpClientFactory" Version="7.2.22"/>
+        <PackageReference Include="Polly" Version="8.5.2" />
+        <PackageReference Include="Refit.HttpClientFactory" Version="8.0.0" />
         <PackageReference Include="xunit" Version="2.9.3" />
-        <PackageReference Include="FluentAssertions" Version="7.0.0" />
+        <PackageReference Include="FluentAssertions" Version="8.0.1" />
         <PackageReference Include="Xunit.DependencyInjection" Version="8.9.1" />
         <PackageReference Include="Xunit.DependencyInjection.Logging" Version="8.1.0" />
-        <PackageReference Include="xunit.runner.visualstudio" Version="3.0.0">
+        <PackageReference Include="xunit.runner.visualstudio" Version="3.0.2">
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
             <PrivateAssets>all</PrivateAssets>
         </PackageReference>
-        <PackageReference Include="coverlet.collector" Version="6.0.3">
+        <PackageReference Include="coverlet.collector" Version="6.0.4">
             <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
             <PrivateAssets>all</PrivateAssets>
         </PackageReference>
diff --git a/src/Novu/Novu.csproj b/src/Novu/Novu.csproj
@@ -26,8 +26,8 @@
     <!-- Required Nuget Packages -->
     <ItemGroup>
         <PackageReference Include="Newtonsoft.Json" Version="13.0.3"/>
-        <PackageReference Include="Refit" Version="7.2.22" />
-        <PackageReference Include="Refit.Newtonsoft.Json" Version="7.2.22" />
+        <PackageReference Include="Refit" Version="8.0.0" />
+        <PackageReference Include="Refit.Newtonsoft.Json" Version="8.0.0" />
         <PackageReference Include="System.ComponentModel.Annotations" Version="5.0.0"/>
     </ItemGroup>
 

Original file line number	Diff line number	Diff line change
`@@ -86,7 +86,7 @@ public async Task Should_Get_InApp_Unseen()`
`86`	`86`	`var messagesCount = await subscriberClient.GetInAppUnseen(subscriber.SubscriberId!);`
`87`	`87`
`88`	`88`	`// fire forget test, that it returns something`
`89`		`- messagesCount.Data.Count.Should().BeGreaterOrEqualTo(0);`
	`89`	`+ messagesCount.Data.Count.Should().BeGreaterThanOrEqualTo(0);`
`90`	`90`	`}`
`91`	`91`
`92`	`92`	`[Fact]`
`@@ -97,6 +97,6 @@ public async Task Should_Get_InApp()`
`97`	`97`	`var messages = await subscriberClient.GetInApp(subscriber.SubscriberId!);`
`98`	`98`
`99`	`99`	`// fire forget test, that it returns something`
`100`		`- messages.Data.Should().HaveCountGreaterOrEqualTo(0);`
	`100`	`+ messages.Data.Should().HaveCountGreaterThanOrEqualTo(0);`
`101`	`101`	`}`
`102`	`102`	`}`