smoke test passing

Author: tatarco

apps/api/src/app/workflows-v2/dtos/limit-offset-pagination.dto.ts

@@ -1,5 +1,6 @@
 import { ApiProperty, ApiPropertyOptional } from '@nestjs/swagger';
-import { IsEnum, IsInt, IsNumber, IsOptional, IsString } from 'class-validator';
+import { Transform } from 'class-transformer';
+import { IsEnum, IsInt, IsNumber, IsOptional, IsString, Min } from 'class-validator';
 
 // Enum for sorting direction
 export enum DirectionEnum {
@@ -22,8 +23,15 @@ export function LimitOffsetPaginationQueryDto<T, K extends keyof T>(
       type: 'number',
       required: false,
     })
+    @Transform(({ value }) => {
+      // Convert to number, handle different input types
+      const parsed = Number(value);
+
+      return !Number.isNaN(parsed) ? parsed : undefined;
+    })
     @IsNumber()
     @IsInt()
+    @Min(1) // Optional: ensure minimum limit
     @IsOptional()
     limit?: number;
 
@@ -32,8 +40,15 @@ export function LimitOffsetPaginationQueryDto<T, K extends keyof T>(
       type: 'number',
       required: false,
     })
+    @Transform(({ value }) => {
+      // Convert to number, handle different input types
+      const parsed = Number(value);
+
+      return !Number.isNaN(parsed) ? parsed : undefined;
+    })
     @IsInt()
     @IsNumber()
+    @Min(0) // Ensure non-negative offset
     @IsOptional()
     offset?: number;
 

apps/api/src/app/workflows-v2/dtos/workflow-list-response.dto.ts

@@ -56,6 +56,7 @@ export class WorkflowListResponseDto {
   @ApiProperty({
     description: 'Timestamp of the last workflow trigger',
     required: false,
+    nullable: true,
   })
   @IsOptional()
   @IsString()

apps/api/src/app/workflows-v2/workflow.controller.e2e.ts

@@ -1170,8 +1170,7 @@ describe('Workflow Controller E2E API Testing #novu-v2', () => {
     await validateWorkflowDeleted(id);
   }
   async function validateWorkflowDeleted(workflowId: string): Promise<void> {
-    const { error, successfulBody } = await expectSdkExceptionGeneric(() => novuClient.workflows.retrieve(workflowId));
-    expect(successfulBody).to.be.false;
+    const { error } = await expectSdkExceptionGeneric(() => novuClient.workflows.retrieve(workflowId));
     expect(error).to.be.ok;
     expect(error!.statusCode).to.equal(404);
     await validatePreferencesDeleted(workflowId);

libs/internal-sdk/src/models/components/workflowlistresponsedto.ts

@@ -63,7 +63,7 @@ export type WorkflowListResponseDto = {
   /**
    * Timestamp of the last workflow trigger
    */
-  lastTriggeredAt?: string | undefined;
+  lastTriggeredAt?: string | null | undefined;
   /**
    * Overview of step types in the workflow
    */
@@ -85,7 +85,7 @@ export const WorkflowListResponseDto$inboundSchema: z.ZodType<
   slug: z.string(),
   status: WorkflowStatusEnum$inboundSchema,
   origin: WorkflowOriginEnum$inboundSchema,
-  lastTriggeredAt: z.string().optional(),
+  lastTriggeredAt: z.nullable(z.string()).optional(),
   stepTypeOverviews: z.array(StepTypeEnum$inboundSchema),
 }).transform((v) => {
   return remap$(v, {
@@ -104,7 +104,7 @@ export type WorkflowListResponseDto$Outbound = {
   slug: string;
   status: string;
   origin: string;
-  lastTriggeredAt?: string | undefined;
+  lastTriggeredAt?: string | null | undefined;
   stepTypeOverviews: Array<string>;
 };
 
@@ -123,7 +123,7 @@ export const WorkflowListResponseDto$outboundSchema: z.ZodType<
   slug: z.string(),
   status: WorkflowStatusEnum$outboundSchema,
   origin: WorkflowOriginEnum$outboundSchema,
-  lastTriggeredAt: z.string().optional(),
+  lastTriggeredAt: z.nullable(z.string()).optional(),
   stepTypeOverviews: z.array(StepTypeEnum$outboundSchema),
 }).transform((v) => {
   return remap$(v, {