small module fixes

Author: tatarco

apps/api/scripts/generate-metadata.ts

@@ -1,19 +1,21 @@
-/**
- * This file is responsible for generating Nest.js metadata for the API.
- * Metadata generation is required when using SWC with Nest.js due to SWC
- * not natively supporting Typescript, which is required to use the `reflect-metadata`
- * API and in turn, resolve types for the OpenAPI specification.
- *
- * @see https://docs.nestjs.com/recipes/swc#monorepo-and-cli-plugins
- */
 import fs from 'node:fs';
 import path from 'node:path';
+import { fileURLToPath } from 'node:url';
 import { PluginMetadataGenerator } from '@nestjs/cli/lib/compiler/plugins';
 import { ReadonlyVisitor } from '@nestjs/swagger/dist/plugin';
 
-const tsconfigPath = 'tsconfig.build.json';
-const srcPath = path.join(__dirname, '..', 'src');
-const metadataPath = path.join(srcPath, 'metadata.ts');
+// Get the current file's directory
+const __filename = fileURLToPath(import.meta.url);
+const __dirname = path.dirname(__filename);
+
+// More precise path resolution
+const projectRoot = path.resolve(__dirname, '..', '..');
+const apiRoot = path.resolve(projectRoot, 'api');
+const srcPath = path.resolve(apiRoot, 'src');
+const metadataPath = path.resolve(srcPath, 'metadata.ts');
+
+// Ensure directories exist
+fs.mkdirSync(path.dirname(metadataPath), { recursive: true });
 
 /*
  * We create an empty metadata file to ensure that files importing `metadata.ts`
@@ -24,9 +26,15 @@ const defaultContent = `export default async () => { return {}; };`;
 fs.writeFileSync(metadataPath, defaultContent, 'utf8');
 console.log('metadata.ts file has been generated with default content.');
 
-const generator = new PluginMetadataGenerator();
-generator.generate({
-  visitors: [new ReadonlyVisitor({ introspectComments: true, pathToSource: srcPath })],
-  outputDir: srcPath,
-  tsconfigPath,
-});
+// Wrap in try-catch for better error handling
+try {
+  const generator = new PluginMetadataGenerator();
+  generator.generate({
+    visitors: [new ReadonlyVisitor({ introspectComments: true, pathToSource: srcPath })],
+    outputDir: srcPath,
+    tsconfigPath: 'tsconfig.build.json',
+  });
+} catch (error) {
+  console.error('Error generating metadata:', error);
+  process.exit(1);
+}

apps/api/src/app/content-templates/content-templates.controller.ts

@@ -1,8 +1,7 @@
-/* eslint-disable global-require */
 import { Body, Controller, Logger, Post } from '@nestjs/common';
 import { ApiExcludeController } from '@nestjs/swagger';
 import { format } from 'date-fns';
-import i18next from 'i18next';
+import i18next, { i18n } from 'i18next';
 import { ModuleRef } from '@nestjs/core';
 import {
   ApiException,
@@ -148,18 +147,24 @@ export class ContentTemplatesController {
     );
   }
 
-  protected async initiateTranslations(environmentId: string, organizationId: string, locale: string | undefined) {
+  async initiateTranslations(
+    environmentId: string,
+    organizationId: string,
+    locale: string | undefined
+  ): Promise<i18n | undefined> {
     try {
       if (process.env.NOVU_ENTERPRISE === 'true' || process.env.CI_EE_TEST === 'true') {
+        // eslint-disable-next-line global-require
         if (!require('@novu/ee-shared-services')?.TranslationsService) {
           throw new ApiException('Translation module is not loaded');
         }
+        // eslint-disable-next-line global-require
         const service = this.moduleRef.get(require('@novu/ee-shared-services')?.TranslationsService, { strict: false });
         const { namespaces, resources, defaultLocale } = await service.getTranslationsList(
           environmentId,
           organizationId
         );
-        const instance = i18next.createInstance();
+        const instance: i18n = i18next.createInstance();
         await instance.init({
           resources,
           ns: namespaces,
@@ -184,6 +189,7 @@ export class ContentTemplatesController {
       }
     } catch (e) {
       Logger.error(e, `Unexpected error while importing enterprise modules`, 'TranslationsService');
+      throw e;
     }
   }
 }