feat(cli): Warn about unused disabled detectors

Closes #393

Author: jubnzv

CHANGELOG.md

@@ -14,6 +14,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 - `DuplicatedImport` and `TransitiveImport`: Don't check internal stdlib imports
 - `ZeroAddress` and `ConstantAddress`: Ignore uses in comparisons: Issue [#384](https://github.com/nowarp/misti/issues/384)
+- Warn if one of the disabled detectors (`-dd`) is unused: Issue [#393](https://github.com/nowarp/misti/issues/393)
 
 ### Fixed
 - `ImportGraph`: Set correct file paths of import nodes for `.func` files: PR [#381](https://github.com/nowarp/misti/pull/381)

src/cli/driver.ts

@@ -272,10 +272,12 @@ export class Driver {
    * @throws Error if a detector class cannot be found in the specified module or as a built-in.
    */
   async initializeDetectors(): Promise<void> {
+    const usedDisabledDetectors = new Set<string>();
     const detectorPromises = this.ctx.config.detectors.reduce<
       Promise<Detector | null>[]
     >((acc, config) => {
       if (this.disabledDetectors.has(config.className)) {
+        usedDisabledDetectors.add(config.className);
         this.ctx.logger.debug(`Suppressed detector: ${config.className}`);
         return acc;
       }
@@ -311,6 +313,16 @@ export class Driver {
     this.ctx.logger.debug(
       `Enabled detectors (${this.detectors.length}): ${this.detectors.map((d) => d.id).join(", ")}`,
     );
+
+    // Warn about unused disabled detectors
+    const unusedDisabledDetectors = [...this.disabledDetectors].filter(
+      (detector) => !usedDisabledDetectors.has(detector),
+    );
+    if (unusedDisabledDetectors.length > 0) {
+      this.ctx.logger.warn(
+        `The following disabled detectors were never encountered: ${unusedDisabledDetectors.join(", ")}`,
+      );
+    }
   }
 
   /**