Update pylint requirement from ~=2.17 to ~=3.3

Updates the requirements on
[pylint](https://github.com/pylint-dev/pylint) to permit the latest
version.
- [Release notes](https://github.com/pylint-dev/pylint/releases)
- [Commits](pylint-dev/pylint@v2.17.0...v3.3.7)

Also specify py-version, add PYLINTFLAGS to Makefile, use the GitHub
workflow format for Pylint, enable Python 3.12 and 3.13 for CI, spell
out make dependencies and dependencies-dev, treat warnings as errors for
unit tests, fix make clean POSIX incompatibility, vendor fonts with
package.json, migrate .mypy.ini and .pylintrc to pyproject.toml and
specify files in the mypy configuration.

Close #25.

---
updated-dependencies:
- dependency-name: pylint
  dependency-version: 3.3.7
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>

Author: dependabot[bot]

.github/workflows/check.yaml

@@ -1,4 +1,4 @@
-name: Check code
+name: Check Code
 on:
     - push
     - pull_request
@@ -10,14 +10,16 @@ jobs:
                     - "3.9"
                     - "3.10"
                     - "3.11"
+                    - "3.12"
+                    - "3.13"
         runs-on: ubuntu-latest
         steps:
             - uses: actions/checkout@v3
             - uses: actions/setup-python@v4
               with:
                   python-version: ${{ matrix.python }}
-            - run: make deps deps-dev
+            - run: make dependencies dependencies-dev
             - run: make type
             - run: make test
-            - run: make lint
+            - run: make lint PYLINTFLAGS=--output-format=github
               continue-on-error: ${{ contains(github.event.head_commit.message, 'WIP') }}

.mypy.ini

@@ -1,45 +1,39 @@
 PYTHON=python3
+PYTHONFLAGS=-W error
 PIP=pip3
 PIPFLAGS=--upgrade
+PYLINTFLAGS=
 NPM=npm
 NPMFLAGS=--no-save
 
 .PHONY: test
 test:
-	$(PYTHON) -m unittest
+	$(PYTHON) $(PYTHONFLAGS) -m unittest
 
 .PHONY: type
 type:
-	mypy flatdir
+	mypy
 
 .PHONY: lint
 lint:
-	pylint flatdir
+	pylint $(PYLINTFLAGS) flatdir
 
 .PHONY: check
 check: type test lint
 
-.PHONY: deps
-deps:
-	$(PIP) install $(PIPFLAGS) --requirement requirements.txt
+.PHONY: dependencies
+dependencies:
+	$(PIP) install $(PIPFLAGS) --requirement=requirements.txt
 
-.PHONY: deps-dev
-deps-dev:
-	$(PIP) install $(PIPFLAGS) --requirement requirements-dev.txt
+.PHONY: dependencies-dev
+dependencies-dev:
+	$(PIP) install $(PIPFLAGS) --requirement=requirements-dev.txt
 
-FONTSMODULE=node_modules/@fontsource/noto-sans
-FONTSRESOURCE=flatdir/res/fonts
 .PHONY: fonts
 fonts:
 	@# Work around npm 7 update modifying package.json (see https://github.com/npm/cli/issues/3044)
 	$(NPM) install $(NPMFLAGS)
-	mkdir --parents $(FONTSRESOURCE)/files
-	cp $(FONTSMODULE)/400.css $(FONTSMODULE)/600.css $(FONTSRESOURCE)/
-	cp $(FONTSMODULE)/files/noto-sans-*-400-normal.woff2 \
-	    $(FONTSMODULE)/files/noto-sans-all-400-normal.woff \
-	    $(FONTSMODULE)/files/noto-sans-*-600-normal.woff2 \
-	    $(FONTSMODULE)/files/noto-sans-all-600-normal.woff $(FONTSRESOURCE)/files/
 
 .PHONY: clean
 clean:
-	rm --recursive --force $$(find . -name __pycache__) .mypy_cache node_modules
+	rm -rf $$(find . -name __pycache__) .mypy_cache node_modules

.pylintrc

@@ -17,7 +17,6 @@
 
 from collections.abc import Mapping
 from enum import Enum
-from importlib.abc import Traversable
 from itertools import chain
 import logging
 from logging import Formatter, LogRecord, StreamHandler
@@ -27,6 +26,14 @@
 from typing import Iterable, Literal, TextIO, TypeVar, cast, overload
 from xml.etree.ElementTree import Element
 
+if sys.version_info < (3, 11):
+    # Work around Pylint rejecting deprecated features in compatibility code (see
+    # https://github.com/pylint-dev/pylint/issues/9533)
+    # pylint: disable=deprecated-class
+    from importlib.abc import Traversable
+else:
+    from importlib.resources.abc import Traversable
+
 FormatStyle = Literal['%', '{', '$']
 
 T = TypeVar('T')

Makefile

@@ -1,4 +1,13 @@
 {
+    "scripts": {
+        "dependencies": "mkdir -p flatdir/res/fonts/files && cp $npm_package_config_vendored_root flatdir/res/fonts/ && cp $npm_package_config_vendored_files flatdir/res/fonts/files/"
+    },
+    "config": {
+        "vendored": {
+            "root": "node_modules/@fontsource/noto-sans/400.css node_modules/@fontsource/noto-sans/600.css",
+            "files": "node_modules/@fontsource/noto-sans/files/noto-sans-*-400-normal.woff2 node_modules/@fontsource/noto-sans/files/noto-sans-all-400-normal.woff node_modules/@fontsource/noto-sans/files/noto-sans-*-600-normal.woff2 node_modules/@fontsource/noto-sans/files/noto-sans-all-600-normal.woff"
+        }
+    },
     "dependencies": {
         "@fontsource/noto-sans": "^4.5"
     }

flatdir/util.py

@@ -0,0 +1,17 @@
+[tool.mypy]
+files = ["flatdir"]
+strict = true
+disallow_any_expr = true
+disallow_any_decorated = true
+disallow_any_explicit = true
+
+[tool.pylint.main]
+disable = [
+    # Good design is best figured out by humans yet
+    "design", "too-many-lines", "too-many-nested-blocks",
+    # Handled by mypy
+    "classes", "typecheck"
+]
+jobs = 0
+output-format = "colorized"
+py-version = "3.9"

package.json

@@ -1,2 +1,2 @@
 mypy ~= 1.2
-pylint ~= 2.17
+pylint ~= 3.3