Always close connection after reloading types in migration. (#3465)

marcusber · roji · commit 6a3445557d14 · 2025-02-15T19:41:47.000+02:00
Closes #3464 (cherry picked from commit 786b635)
diff --git a/src/EFCore.PG/Migrations/Internal/NpgsqlMigrator.cs b/src/EFCore.PG/Migrations/Internal/NpgsqlMigrator.cs
@@ -85,7 +85,7 @@ public override void Migrate(string? targetMigration)
             {
                 npgsqlConnection.ReloadTypes();
             }
-            catch
+            finally
             {
                 _connection.Close();
             }
@@ -128,7 +128,7 @@ public override async Task MigrateAsync(string? targetMigration, CancellationTok
             {
                 await npgsqlConnection.ReloadTypesAsync(cancellationToken).ConfigureAwait(false);
             }
-            catch
+            finally
             {
                 await _connection.CloseAsync().ConfigureAwait(false);
             }

Original file line number	Diff line number	Diff line change
`@@ -85,7 +85,7 @@ public override void Migrate(string? targetMigration)`
`85`	`85`	`{`
`86`	`86`	`npgsqlConnection.ReloadTypes();`
`87`	`87`	`}`
`88`		`- catch`
	`88`	`+ finally`
`89`	`89`	`{`
`90`	`90`	`_connection.Close();`
`91`	`91`	`}`
`@@ -128,7 +128,7 @@ public override async Task MigrateAsync(string? targetMigration, CancellationTok`
`128`	`128`	`{`
`129`	`129`	`await npgsqlConnection.ReloadTypesAsync(cancellationToken).ConfigureAwait(false);`
`130`	`130`	`}`
`131`		`- catch`
	`131`	`+ finally`
`132`	`132`	`{`
`133`	`133`	`await _connection.CloseAsync().ConfigureAwait(false);`
`134`	`134`	`}`