New Version Breaks Electron (possibly non-browser NodeJS as well)

[barrycaceres]

I was using "is-dom" indirectly via the "console-redirect" module from my electron-main.js. This was working forever until this last week when electron got an error about "window" not being defined during startup.

I had to change my package.json to explicitly require version 1.0.9 to avoid the problem.

[TehShrike]

That sucks.

We should be testing with electron instead of jsdom. Code coverage doesn't matter in a one-function module like this.

Can you paste what the error message was exactly? Maybe grab the stack trace?

[barrycaceres]

I will revert the package dependency and grab the error message on startup before end of the week

[TehShrike]

The unit tests are passing in electron right now. If you can come up with a failing test case to add to the unit tests, that would be excellent.