Skip to content

Version 1.1.0 breaks support for IE10/11 #15

@peterhass

Description

@peterhass

I am using is-dom through embed-js. I was wondering why it started to throw weird errors in IE and started digging deeper ...

Yarn silently updated my projects is-dom package from 1.0.9 to 1.1.0.

Following line causes the problem in IE:

if (!isObject(val) || !isWindow(window) || typeof window.Node !== `function`) {

typeof window.Node !== 'function' always returns true in IE (window.Node is of type 'object')

My temporary workaround is to pin is-dom version to 1.0.9.

{
  "name": "test",
  "version": "0.0.0",
  "dependencies": {
    "embed-js": "^5.0.3",
    "embed-plugin-noembed": "^5.0.3",
  },
  "resolutions": {
    "is-dom": "1.0.9"
  },
  "module": "src/main.js"
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions