Skip to content

Commit 4ece537

Browse files
authored
docs: add meeting notes form 06-23-2021 call
1 parent a6c6044 commit 4ece537

File tree

1 file changed

+103
-0
lines changed

1 file changed

+103
-0
lines changed

meetings/2021-06-23.md

Lines changed: 103 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,103 @@
1+
#### Meeting from: June 23rd, 2021
2+
3+
# Open RFC Meeting (npm)
4+
5+
### Attendees
6+
- Darcy Clarke (@darcyclarke)
7+
- Wes Todd (@wesleytodd)
8+
- Isaac Z. Schlueter (@isaacs)
9+
- Ruy Adorno (@ruyadorno)
10+
- Nathan LaFreniere (@nlf)
11+
- Gar (@wraithgar)
12+
- Rebecca Turner (@iarna)
13+
- Jordan Harband (@ljharb)
14+
15+
### Agenda
16+
17+
1. **Housekeeping**
18+
1. Introduction(s)
19+
1. [Code of Conduct Acknowledgement](https://www.npmjs.com/policies/conduct)
20+
1. Outline Intentions & Desired Outcomes
21+
1. Announcements
22+
1. **PR**: [#3456 feat: add prefix for version output](https://github.com/npm/cli/pull/3456) - @cyntler
23+
1. **PR**: [#3437 fix(ls/search) --json arg error also sent to stdout](https://github.com/npm/cli/pull/3437) - @RammasEchor
24+
1. **Issue**: [#398 [RRFC] Top-level command to manage package.json](https://github.com/npm/rfcs/issues/398) - @ruyadorno
25+
1. **PR**: [#3397 feat(config): add in-range](https://github.com/npm/cli/pull/3397) - @wraithgar
26+
1. **PR**: [#392 RFC: group outdated packages by dependency type](https://github.com/npm/rfcs/pull/392) - @thiagodp
27+
1. **Issue**: [#390 [RRFC] npm publish should fail when the `files` is misconfig in package.json](https://github.com/npm/rfcs/issues/390) - @aladdin-add
28+
1. **PR**: [#343 RFC: npm workspaces: auto switch context based on cwd](https://github.com/npm/rfcs/pull/343) - @ruyadorno
29+
1. **PR**: [#319 feat(multiple-dist-tags): add proposal for multiple dist-tags](https://github.com/npm/rfcs/pull/319) - @wraithgar
30+
1. **PR**: [#273 RFC: npm workspaces - Config management](https://github.com/npm/rfcs/pull/273) - @ruyadorno
31+
1. **PR**: [#182 RFC: npm audit licenses](https://github.com/npm/rfcs/pull/182) - @bnb
32+
33+
### Notes
34+
35+
#### **PR**: [#3456 feat: add prefix for version output](https://github.com/npm/cli/pull/3456) - @cyntler
36+
- @wraithgar this is a breaking change
37+
38+
#### **PR**: [#3437 fix(ls/search) --json arg error also sent to stdout](https://github.com/npm/cli/pull/3437) - @RammasEchor
39+
- @wesleytodd
40+
- there's errors you won't be able to handle & can't expect `--json` to catch that
41+
- @iarna
42+
- wouldn't expect STDERR to be JSON
43+
- @ljharb
44+
- would only expect a successful request to output JSON
45+
- @bnb would like to set this
46+
47+
#### **Issue**: [#398 [RRFC] Top-level command to manage package.json](https://github.com/npm/rfcs/issues/398) - @ruyadorno
48+
- @ruyadorno
49+
- Created RFC: https://github.com/npm/rfcs/pull/402
50+
- Updated/refactored internal code to use net-new `@npmcli/package-json`
51+
- @wesleytodd
52+
- nice to be able to format the value w/ a similar syntax to the key
53+
- @isaacs
54+
- should define how we map to keys with dots & make that consistent across `npm config` (getters/setters should work the same in `npm pkg`)
55+
- possibly providing a way to escape strings with a dot: `npm pkg set foo["1.2.3"]=bar`
56+
- @nlf
57+
- npm pkg set tap.timeout=60 means take the tap object and change timeout to 60 within it
58+
- npm pkg set tap={"timeout":60} means replace the entire tap object with the given value
59+
- @ljharb `config` should have dot config deprecated/will be a breaking change
60+
- @wraithgar we can start warning if we see dot config keys so we can eventually remove in next major
61+
62+
#### **PR**: [#3397 feat(config): add in-range](https://github.com/npm/cli/pull/3397) - @wraithgar
63+
- @wraithgar
64+
- `npm outdated` isn't that helpful - color isn't very telling
65+
- @isaacs suggested adding `--dry-run` support to `npm updae
66+
- @ljharb
67+
- seems like theres two use cases here...
68+
- 1. show me all the things that aren't at the latest version
69+
- 2. show me what would be/should be updated if I ran `npm update`
70+
- @isaacs
71+
- we should be printing the diff from reify when passed `--dry-run`
72+
- @iarna out-of-range updates implies not reporting on transitive dependencies too, which nicely simplifies the output you have to have
73+
74+
#### **PR**: [#392 RFC: group outdated packages by dependency type](https://github.com/npm/rfcs/pull/392) - @thiagodp
75+
- @isaacs: sort by "first dep type a given name is found in", and then by "name"
76+
- @wraithgar: just need to be clear about the priority ordering
77+
78+
79+
#### **Issue**: [#390 [RRFC] npm publish should fail when the `files` is misconfig in package.json](https://github.com/npm/rfcs/issues/390) - @aladdin-add
80+
- @isaacs Implementation is more complex than it seems due to the nature of globs patterns and the interaction between multiple defined patterns from different places `.gitignore`, `.npmignore` and `files` package.json property
81+
- @ljharb it would be extremely helpful to warn & eventually error
82+
- @isaacs
83+
- could potentially do this if the rule is "every non-negated entry in `"files"` must match 1 or more filesystem entries"
84+
- would treat `{a,b}` as a "pass, no warn" if `a` is found and `b` isn't. Warn if any non-negated entry in `files` does not have 1 or more matches, and `{a,b}` had a match if `a` is found and `b` isn't.
85+
- `"files": ["lib"]` if `lib/` exists, but is empty, we won't actually put anything in the package, but the pattern had a match, so no warning.
86+
- What if you have `"files": ["lib/*.js", "!lib/foo.js"]` and the only file in `lib/` is `lib/foo.js`? The first entry had a match, but then it was negated out.
87+
- This sounds simple, but it is deceptively complicated.
88+
- @wraithgar feels like we're continuing to circle the drain on guessing user intent; There are other mechanisms for this like prepare/prepublish lifecycle events
89+
- @nlf very much agreed. if you want to assert that your files array is right, that's up to you. having that templated is useful and i'd be somewhat annoyed if my template started throwing errors because i haven't created a bin directory in my repo
90+
- @isaacs `^` THIS
91+
92+
#### **PR**: [#343 RFC: npm workspaces: auto switch context based on cwd](https://github.com/npm/rfcs/pull/343) - @ruyadorno
93+
- @ruyadorno no updates
94+
95+
#### **PR**: [#319 feat(multiple-dist-tags): add proposal for multiple dist-tags](https://github.com/npm/rfcs/pull/319) - @wraithgar
96+
- @wraithgar no updates
97+
98+
#### **PR**: [#273 RFC: npm workspaces - Config management](https://github.com/npm/rfcs/pull/273) - @ruyadorno
99+
- @ruyadorno no updates
100+
101+
#### **PR**: [#182 RFC: npm audit licenses](https://github.com/npm/rfcs/pull/182) - @bnb
102+
- @bnb
103+
- got initial work done to open a PR (ref. https://github.com/npm/cli/pull/3452) - barebones

0 commit comments

Comments
 (0)