tests: on_target: memfault test uses debug hex

Now memfault is only built on debug build.

Signed-off-by: Giacomo Dematteis <giacomo.dematteis@nordicsemi.no>

Author: DematteisGiacomo

.github/workflows/publish-symbol-files-to-memfault.yml

@@ -32,26 +32,7 @@ jobs:
 
       - run: node .github/workflows/fetch-release-assets.mjs ${{ inputs.version }}
 
-      - name: Publish symbol files
-        run: |
-          source venv/bin/activate
-          memfault \
-              --org-token ${{ secrets.MEMFAULT_ORGANIZATION_TOKEN }} \
-              --org ${{ vars.MEMFAULT_ORGANIZATION_SLUG }} \
-              --project ${{ vars.MEMFAULT_PROJECT_SLUG }} \
-              upload-mcu-symbols \
-              --check-uploaded \
-              asset-tracker-template-${{ inputs.version }}-thingy91x-nrf91.elf
-
-          memfault \
-              --org-token ${{ secrets.MEMFAULT_ORGANIZATION_TOKEN }} \
-              --org ${{ vars.MEMFAULT_ORGANIZATION_SLUG }} \
-              --project ${{ vars.MEMFAULT_PROJECT_SLUG }} \
-              upload-mcu-symbols \
-              --check-uploaded \
-              asset-tracker-template-${{ inputs.version }}-nrf9151dk-nrf91.elf
-
-      - name: Publish debug symbol files
+      - name: Publish Memfault debug symbols
         run: |
           source venv/bin/activate
           memfault \

.github/workflows/target-test.yml

@@ -128,7 +128,7 @@ jobs:
           nrfutil install trace
 
       - name: Upload symbol file to Memfault
-        if: ${{ matrix.device != 'ppk_thingy91x' }}
+        if: ${{ matrix.device == 'thingy91x' }}
         working-directory: asset-tracker-template/tests/on_target/artifacts
         run: |
           memfault \
@@ -137,7 +137,7 @@ jobs:
               --project ${{ vars.MEMFAULT_PROJECT_SLUG }} \
               upload-mcu-symbols \
               --check-uploaded \
-              asset-tracker-template-${{ inputs.artifact_fw_version }}-${{ vars.DUT_DEVICE_TYPE }}-nrf91.elf
+              asset-tracker-template-${{ inputs.artifact_fw_version }}-debug-${{ vars.DUT_DEVICE_TYPE }}-nrf91.elf
 
       - name: Generate and Push RAM and FLASH Badges
         if: ${{ matrix.device == 'thingy91x' && inputs.is_scheduled }}

tests/on_target/tests/conftest.py

@@ -140,6 +140,18 @@ def hex_file():
 
     pytest.fail("No matching firmware .hex file found in the artifacts directory")
 
+@pytest.fixture(scope="session")
+def debug_hex_file():
+    # Search for the debug firmware hex file in the artifacts folder
+    artifacts_dir = "artifacts/"
+    hex_pattern = f"asset-tracker-template-{r'[0-9a-z\.]+'}-debug-{DUT_DEVICE_TYPE}-nrf91.hex"
+
+    for file in os.listdir(artifacts_dir):
+        if re.match(hex_pattern, file):
+            return os.path.join(artifacts_dir, file)
+
+    pytest.fail("No matching debug firmware .hex file found in the artifacts directory")
+
 @pytest.fixture(scope="session")
 def bin_file():
     # Search for the firmware bin file in the artifacts folder

tests/on_target/tests/test_functional/test_memfault.py

@@ -89,14 +89,17 @@ def timestamp(event):
         event["captured_date"], "%Y-%m-%dT%H:%M:%S.%f%z"
     )
 
-def test_memfault(dut_board, hex_file):
+def test_memfault(dut_board, debug_hex_file):
+    if dut_board.device_type != 'thingy91x':
+        pytest.skip("Memfault testing requires debug build which is only available for thingy91x")
+
     # Save timestamp of latest coredump
     coredumps = get_latest_coredump_traces(IMEI)
     logger.debug(f"Found coredumps: {coredumps}")
     timestamp_old_coredump = timestamp(coredumps[0]) if coredumps else  None
     logger.debug(f"Timestamp old coredump: {timestamp_old_coredump}")
 
-    flash_device(os.path.abspath(hex_file))
+    flash_device(os.path.abspath(debug_hex_file))
     dut_board.uart.xfactoryreset()
     dut_board.uart.flush()
     reset_device()