modules: cloud: Optimize event handling and clean up configuration

- Streamlined some output events from the cloud module.
- Remove unused configuration option from Kconfig.cloud.

Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>

Author: simensrostad

app/src/main.c

@@ -400,7 +400,7 @@ static void idle_run(void *o)
 	if (state_object->chan == &CLOUD_CHAN) {
 		struct cloud_msg msg = MSG_TO_CLOUD_MSG(state_object->msg_buf);
 
-		if (msg.type == CLOUD_CONNECTED_READY_TO_SEND) {
+		if (msg.type == CLOUD_CONNECTED) {
 			state_object->connected = true;
 			smf_set_state(SMF_CTX(state_object), &states[STATE_TRIGGERING]);
 			return;
@@ -454,8 +454,7 @@ static void triggering_run(void *o)
 	if (state_object->chan == &CLOUD_CHAN) {
 		struct cloud_msg msg = MSG_TO_CLOUD_MSG(state_object->msg_buf);
 
-		if ((msg.type == CLOUD_CONNECTED_PAUSED) ||
-		    (msg.type == CLOUD_DISCONNECTED)) {
+		if (msg.type == CLOUD_DISCONNECTED) {
 			state_object->connected = false;
 			smf_set_state(SMF_CTX(state_object), &states[STATE_IDLE]);
 			return;

app/src/modules/cloud/Kconfig.cloud

@@ -87,12 +87,6 @@ config APP_CLOUD_MESSAGE_QUEUE_SIZE
 	help
 	  ZBus subscriber message queue size.
 
-config APP_CLOUD_POLL_INTERVAL_SECONDS
-	int "Poll interval in seconds"
-	default 10
-	help
-	  Interval in seconds between polling nRF Cloud CoAP.
-
 config APP_CLOUD_WATCHDOG_TIMEOUT_SECONDS
 	int "Watchdog timeout"
 	default 180

app/src/modules/cloud/cloud_module.c

@@ -527,7 +527,7 @@ static void state_connected_ready_entry(void *o)
 {
 	int err;
 	struct cloud_msg cloud_msg = {
-		.type = CLOUD_CONNECTED_READY_TO_SEND,
+		.type = CLOUD_CONNECTED,
 	};
 
 	ARG_UNUSED(o);
@@ -703,7 +703,7 @@ static void state_connected_paused_entry(void *o)
 {
 	int err;
 	struct cloud_msg cloud_msg = {
-		.type = CLOUD_CONNECTED_PAUSED,
+		.type = CLOUD_DISCONNECTED,
 	};
 
 	ARG_UNUSED(o);

app/src/modules/cloud/cloud_module.h

@@ -33,8 +33,7 @@ struct cloud_shadow_response {
 
 enum cloud_msg_type {
 	CLOUD_DISCONNECTED = 0x1,
-	CLOUD_CONNECTED_READY_TO_SEND,
-	CLOUD_CONNECTED_PAUSED,
+	CLOUD_CONNECTED,
 	CLOUD_CONNECTION_ATTEMPT_COUNT_REACHED,
 	CLOUD_PAYLOAD_JSON,
 	CLOUD_POLL_SHADOW,