ci: Only run MQTT test on nighty (slow)

This commit modifies the GitHub Actions workflow to only run the MQTT
test on the nightly build. This is done to reduce the time taken for
the CI pipeline, as the MQTT test is slow and not needed for every
commit. The test will still be run on the nightly build to ensure that
it is functioning correctly.

Signed-off-by: Simen S. Røstad <simen.rostad@nordicsemi.no>

Author: simensrostad

.github/workflows/target-test.yml

@@ -170,7 +170,6 @@ jobs:
               --junit-xml=results/test-results.xml \
               --html=results/test-results.html --self-contained-html \
               --ignore=tests/test_ppk \
-              --ignore=tests/test_functional/test_mqtt.py \
               ${{ inputs.pytest_path }}
           fi
         shell: bash
@@ -186,27 +185,6 @@ jobs:
           MEMFAULT_PROJECT_SLUG: ${{ vars.MEMFAULT_PROJECT_SLUG }}
           APP_BUNDLEID: ${{ env.APP_BUNDLEID }}
 
-      - name: Test MQTT Firmware
-        if: ${{ matrix.device == 'thingy91x' && endsWith(inputs.artifact_fw_version, '-mqtt') }}
-        working-directory: asset-tracker-template/tests/on_target
-        run: |
-          pytest -v \
-            --junit-xml=results/test-results-mqtt.xml \
-            --html=results/test-results-mqtt.html --self-contained-html \
-            tests/test_functional/test_mqtt.py
-        shell: bash
-        env:
-          SEGGER: ${{ env.RUNNER_SERIAL_NUMBER }}
-          DUT_DEVICE_TYPE: ${{ vars.DUT_DEVICE_TYPE }}
-          UUID: ${{ env.UUID }}
-          NRFCLOUD_API_KEY: ${{ secrets.NRF_CLOUD_API_KEY }}
-          LOG_FILENAME: att_test_log_mqtt
-          TEST_REPORT_NAME: ATT MQTT Firmware Test Report
-          MEMFAULT_ORGANIZATION_TOKEN: ${{ secrets.MEMFAULT_ORGANIZATION_TOKEN }}
-          MEMFAULT_ORGANIZATION_SLUG: ${{ vars.MEMFAULT_ORGANIZATION_SLUG }}
-          MEMFAULT_PROJECT_SLUG: ${{ vars.MEMFAULT_PROJECT_SLUG }}
-          APP_BUNDLEID: ${{ env.APP_BUNDLEID }}
-
       - name: Generate and Push Power Badge
         if: ${{ matrix.device }} == ppk_thingy91x
         continue-on-error: true

tests/on_target/tests/conftest.py

@@ -183,3 +183,19 @@ def hex_file_patched():
             return os.path.join(artifacts_dir, file)
 
     pytest.fail("No matching firmware .hex file found in the artifacts directory")
+
+@pytest.fixture(scope="session")
+def hex_file_mqtt():
+    # Skip if not thingy91x since MQTT build is only available for thingy91x
+    if DUT_DEVICE_TYPE != 'thingy91x':
+        pytest.skip("mqtt build is only available for thingy91x")
+
+    # Search for the firmware hex file in the artifacts folder
+    artifacts_dir = "artifacts/"
+    hex_pattern = f"asset-tracker-template-{r"[0-9a-z\.]+"}-mqtt-{DUT_DEVICE_TYPE}-nrf91.hex"
+
+    for file in os.listdir(artifacts_dir):
+        if re.match(hex_pattern, file):
+            return os.path.join(artifacts_dir, file)
+
+    pytest.fail("No matching firmware .hex file found in the artifacts directory")

tests/on_target/tests/test_functional/test_mqtt.py

@@ -13,15 +13,16 @@
 
 logger = get_logger()
 
-def test_mqtt_firmware(dut_board, hex_file):
-    """Test the MQTT firmware with magnetometer functionality."""
+@pytest.mark.slow
+def test_mqtt_firmware(dut_board, hex_file_mqtt):
+    """Test the firmware with cloud MQTT module."""
     # Only run this test for thingy91x devices
     devicetype = os.getenv("DUT_DEVICE_TYPE")
     if devicetype != "thingy91x":
         pytest.skip("This test is only for thingy91x devices")
 
     # Flash the firmware
-    flash_device(os.path.abspath(hex_file))
+    flash_device(os.path.abspath(hex_file_mqtt))
     dut_board.uart.xfactoryreset()
 
     # Log patterns to check