workflow: Fix the build_all parameter

Signed-off-by: Jorgen Kvalvaag <jorgen.kvalvaag@nordicsemi.no>

Author: jorgenmk

.github/workflows/build-and-target-test.yml

@@ -6,8 +6,13 @@ on:
       build_all:
         description: Build all configurations
         type: boolean
-        required: false
+        required: true
         default: false
+      boards:
+        description: Boards to test, json list
+        type: string
+        required: true
+        default: '["thingy91x"]'
 
   schedule:
     - cron: "0 0 * * *"
@@ -17,11 +22,36 @@ on:
     paths-ignore:
       - "docs/**"
 jobs:
+  setup:
+    runs-on: ubuntu-latest
+    outputs:
+      boards: steps.setup.outputs.boards
+      build_all: steps.setup.outputs.build_all
+    steps:
+      - name: Setup
+        id: setup
+        run: |
+          SCHEDULED=${{ github.event_name == 'schedule' }}
+          PUSH=${{ github.event_name == 'push' }}
+          BUILD_ALL=${{ inputs.build_all }}
+          if [[ $SCHEDULED == true ]]; then
+            boards='["thingy91x","nrf9151dk","ppk_thingy91x"]'
+            build_all=true
+          elif [[ $PUSH == true ]]; then
+            boards='["thingy91x"]'
+            build_all=false
+          else
+            boards=${{ inputs.boards }}
+            build_all=${{ inputs.build_all }}
+          fi
+          echo "boards=$boards" >> $GITHUB_OUTPUT
+          echo "build_all=$build_all" >> $GITHUB_OUTPUT
   build:
+    needs: setup
     uses: ./.github/workflows/build.yml
     secrets: inherit
     with:
-      build_all: ${{ inputs.build_all || false }}
+      build_all: ${{ needs.setup.outputs.build_all }}
   test:
     permissions:
       actions: read
@@ -33,4 +63,5 @@ jobs:
     with:
       artifact_fw_version: ${{ needs.build.outputs.version }}
       artifact_run_id: ${{ needs.build.outputs.run_id }}
-      test_all: ${{ inputs.build_all || false }}
+      devices: ${{ needs.setup.outputs.boards }}
+      test_all: ${{ needs.setup.outputs.build_all }}

.github/workflows/build.yml

@@ -26,7 +26,7 @@ on:
       build_all:
         type: boolean
         required: false
-        default: ${{ github.event_name == 'schedule' }}
+        default: false
     outputs:
       run_id:
         description: The run ID of the workflow to fetch artifacts from

.github/workflows/target-test.yml

@@ -50,40 +50,12 @@ on:
         default: '[\"thingy91x\"]'
 
 jobs:
-  set-matrix:
-    runs-on: ubuntu-latest
-    outputs:
-      device_matrix: ${{ steps.set-matrix.outputs.device_matrix }}
-      pytest_marker: ${{ steps.set-matrix.outputs.pytest_marker }}
-    steps:
-      - id: set-matrix
-        run: |
-          if [[ ${{ github.event_name == 'schedule' }} == true ]]; then
-            marker=''
-            matrix='["thingy91x","nrf9151dk","ppk_thingy91x"]'
-          elif [[ ${{ inputs.test_all }} == true ]]; then
-            marker=''
-            matrix='["thingy91x","nrf9151dk","ppk_thingy91x"]'
-          elif [[ ${{ github.event_name == 'push' }} == true ]]; then
-            marker='-m "not slow"'
-            matrix='["thingy91x"]'
-          else
-            marker='-m "not slow"'
-            matrix='["thingy91x"]'
-          fi
-
-          echo Matrix as string: $matrix
-          echo Pytest marker as string: $marker
-          echo "device_matrix=$matrix" >> $GITHUB_OUTPUT
-          echo "pytest_marker=$marker" >> $GITHUB_OUTPUT
-
   target_test:
     # This will create multiple jobs, one for each target defined in the matrix
-    needs: set-matrix
     strategy:
       fail-fast: false # Don't fail all jobs if one fails
       matrix:
-        device: ${{ fromJson(needs.set-matrix.outputs.device_matrix) }}
+        device: ${{ fromJson(inputs.devices) }}
 
     # Self-hosted runner is labeled according to the device it is linked with
     runs-on: cia-trd-${{ matrix.device }}
@@ -155,14 +127,19 @@ jobs:
         working-directory: asset-tracker-template/tests/on_target
         run: |
           mkdir -p results
+          if [[ ${{ inputs.test_all }} == true ]]; then
+            pytest_marker='-m "not slow"'
+          else
+            pytest_marker=''
+          fi
           if [[ '${{ matrix.device }}' == 'ppk_thingy91x' ]]; then
             # For PPK device, only run tests/test_ppk
-            pytest -v ${{ needs.set-matrix.outputs.pytest_marker }} \
+            pytest -v $pytest_marker \
               --junit-xml=results/test-results.xml \
               --html=results/test-results.html --self-contained-html \
               tests/test_ppk
           else
-            pytest -v ${{ needs.set-matrix.outputs.pytest_marker }} \
+            pytest -v $pytest_marker \
               --junit-xml=results/test-results.xml \
               --html=results/test-results.html --self-contained-html \
               --ignore=tests/test_ppk \