app: main: fix state machine

Set STATE IDLE as initial state in STATE_RUNNNIG.
And do transitions from there.

Signed-off-by: Giacomo Dematteis <giacomo.dematteis@nordicsemi.no>

Author: DematteisGiacomo

app/src/main.c

@@ -150,11 +150,11 @@ static struct app_state_object app_state;
 /* Construct state table */
 static const struct smf_state states[] = {
 	[STATE_RUNNING] = SMF_CREATE_STATE(
-		running_entry,
+		NULL,
 		running_run,
 		NULL,
 		NULL,
-		NULL
+		&states[STATE_IDLE]
 	),
 	[STATE_TRIGGERING] = SMF_CREATE_STATE(
 		triggering_entry,
@@ -305,23 +305,6 @@ static void timer_work_fn(struct k_work *work)
 /* Zephyr State Machine framework handlers */
 
 /* STATE_RUNNING */
-
-static void running_entry(void *o)
-{
-	const struct app_state_object *state_object = (const struct app_state_object *)o;
-
-	LOG_DBG("%s", __func__);
-
-	if (state_object->status == CLOUD_CONNECTED_READY_TO_SEND ||
-	    state_object->status == CLOUD_PAYLOAD_JSON ||
-	    state_object->status == CLOUD_POLL_SHADOW) {
-		STATE_SET(app_state, STATE_TRIGGERING);
-		return;
-	}
-
-	STATE_SET(app_state, STATE_IDLE);
-}
-
 static void running_run(void *o)
 {
 	const struct app_state_object *state_object = (const struct app_state_object *)o;
@@ -370,7 +353,9 @@ static void idle_run(void *o)
 	const struct app_state_object *state_object = (const struct app_state_object *)o;
 
 	if ((state_object->chan == &CLOUD_CHAN) &&
-		(state_object->status == CLOUD_CONNECTED_READY_TO_SEND)) {
+		((state_object->status == CLOUD_CONNECTED_READY_TO_SEND) ||
+		 (state_object->status == CLOUD_PAYLOAD_JSON) ||
+		 (state_object->status == CLOUD_POLL_SHADOW))) {
 		STATE_SET(app_state, STATE_TRIGGERING);
 		return;
 	}