Skip to content

docs: Integrate docs with Zoomin#147

Merged
markaj-nordic merged 1 commit into
nrfconnect:mainfrom
kg-nordicsemi:integrate-docs-with-zoomin
Mar 31, 2026
Merged

docs: Integrate docs with Zoomin#147
markaj-nordic merged 1 commit into
nrfconnect:mainfrom
kg-nordicsemi:integrate-docs-with-zoomin

Conversation

@kg-nordicsemi
Copy link
Copy Markdown
Collaborator

@kg-nordicsemi kg-nordicsemi commented Mar 25, 2026

  • Add doc_build.yml workflow for building docs preparing Azure and Zoomin upload artifacts.
  • Add doc_publish.yml workflow for publishing docs to Azure Storage and Zoomin using SFTP.
  • Add doc_remove.yml workflow for cleaning up PR preview docs from Azure Storage.
  • Add _zoomin/aliro.custom.properties and _zoomin/aliro.tags.yml for Zoomin metadata.

@kg-nordicsemi kg-nordicsemi force-pushed the integrate-docs-with-zoomin branch from 3cc314e to 3656deb Compare March 25, 2026 11:09
@kg-nordicsemi kg-nordicsemi marked this pull request as draft March 25, 2026 11:10
@kg-nordicsemi kg-nordicsemi changed the title docs: Integrate Aliro docs with Zoomin docs: Integrate docs with Zoomin Mar 25, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds automation and metadata to build Sphinx documentation and publish it to Zoomin for both “latest” and release-tagged versions.

Changes:

  • Add reusable GitHub Actions workflow to build, package, and upload/publish docs to Zoomin via SFTP.
  • Add push-based workflows to publish on main docs changes and on version tag pushes.
  • Add docs build script plus Zoomin metadata files (custom.properties, tags.yml).

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
docs/tags.yml Introduces Zoomin tag mappings with version placeholders.
docs/generate_docs.sh Adds a helper script to create a venv, install Sphinx deps, and build HTML docs.
docs/custom.properties Adds Zoomin custom properties with version placeholders.
.github/workflows/publish_documentation.yaml Reusable workflow to build docs, zip them, and publish to Zoomin.
.github/workflows/on_push_tag.yaml Triggers publishing on version tags.
.github/workflows/on_push_publish_documentation.yaml Triggers publishing “latest” on main docs changes and manual dispatch.
Comments suppressed due to low confidence (1)

docs/tags.yml:10

  • mapping_topics: is currently declared without a value, which YAML parses as null. If the Zoomin tag mapping expects a mapping/object, this can break processing; set it to an explicit empty map (e.g., {}) until topic-specific tags are added.
mapping_topics:


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/on_push_tag.yaml Outdated
Comment thread .github/workflows/publish_documentation.yaml Outdated
Comment thread .github/workflows/publish_documentation.yaml Outdated
@kg-nordicsemi kg-nordicsemi force-pushed the integrate-docs-with-zoomin branch 3 times, most recently from 8d89480 to 2b5dec8 Compare March 30, 2026 08:52
Copy link
Copy Markdown
Collaborator

@b-gent b-gent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix CI and move this out of draft

Comment thread docs/_zoomin/aliro.tags.yml Outdated
Comment thread docs/_zoomin/aliro.tags.yml Outdated
Comment thread docs/_zoomin/aliro.tags.yml Outdated
Comment thread docs/_zoomin/aliro.custom.properties Outdated
@markaj-nordic markaj-nordic marked this pull request as ready for review March 31, 2026 07:12
@rami-nordic
Copy link
Copy Markdown
Contributor

General comment: to be able to run and test workflows manually on: workflow_dispatch event can be added:
https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#workflow_dispatch

GH actions allows to pass a parameter to GH action if needed, you could add a default parameter which specifies where docs should be published to be able to test documentation build. Here is the reference example:
https://github.com/nrfconnect/ncs-aliro/blob/main/.github/workflows/sonarqube.yaml#L5

image

- Add doc_build.yml workflow for building docs,
  preparing Azure and Zoomin upload artifacts.
- Add doc_publish.yml workflow for publishing docs
  to Azure Storage and Zoomin using SFTP.
- Add doc_remove.yml workflow for cleaning up
  PR preview docs from Azure Storage.
- Add _zoomin/aliro.custom.properties and
  _zoomin/aliro.tags.yml for Zoomin metadata.

Signed-off-by: Konrad Grucel <konrad.grucel@nordicsemi.no>
@kg-nordicsemi kg-nordicsemi force-pushed the integrate-docs-with-zoomin branch 2 times, most recently from 12ef4db to d756112 Compare March 31, 2026 10:07
@markaj-nordic markaj-nordic requested a review from b-gent March 31, 2026 10:15
@markaj-nordic markaj-nordic merged commit 5f393db into nrfconnect:main Mar 31, 2026
5 checks passed
@kg-nordicsemi kg-nordicsemi deleted the integrate-docs-with-zoomin branch March 31, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants