Skip to content

Commit 12bc2e7

Browse files
doublemis1kkasperczyk-no
authored andcommitted
samples: matter: Fix image-scoped shield variable names
Sysbuild derives the main image name from the application directory. The bridge and weather station docs and test scenarios still used matter_bridge_SHIELD and matter_weather_station_SHIELD, which match no image, so CONFIG_SHIELD and CONFIG_CHIP_WIFI stayed disabled on Wi-Fi builds. Rename to bridge_SHIELD and weather_station_SHIELD, and fix the internal-memory doc example to use the directory name "bridge". Signed-off-by: Michał Szablowski <michal.szablowski@nordicsemi.no>
1 parent 3d414b0 commit 12bc2e7

4 files changed

Lines changed: 10 additions & 10 deletions

File tree

docs/bridge/matter_bridge_description.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -501,7 +501,7 @@ Configuring the number of Bluetooth LE bridged devices
501501

502502
.. group-tab:: |nRFVSC|
503503

504-
Add ``-DSB_CONFIG_WIFI_NRF70=y -Dmatter_bridge_SHIELD=nrf7002eb2 -DCONFIG_BRIDGED_DEVICE_BT=y -DEXTRA_CONF_FILE="bt_max_connections_app.conf"`` to :guilabel:`Extra CMake arguments` in your build configuration.
504+
Add ``-DSB_CONFIG_WIFI_NRF70=y -Dbridge_SHIELD=nrf7002eb2 -DCONFIG_BRIDGED_DEVICE_BT=y -DEXTRA_CONF_FILE="bt_max_connections_app.conf"`` to :guilabel:`Extra CMake arguments` in your build configuration.
505505

506506
.. group-tab:: Command line
507507

@@ -510,7 +510,7 @@ Configuring the number of Bluetooth LE bridged devices
510510
.. parsed-literal::
511511
:class: highlight
512512
513-
west build -b nrf54lm20dk/nrf54lm20b/cpuapp -- -DSB_CONFIG_WIFI_NRF70=y -Dmatter_bridge_SHIELD=nrf7002eb2 -DCONFIG_BRIDGED_DEVICE_BT=y -DEXTRA_CONF_FILE="bt_max_connections_app.conf"
513+
west build -b nrf54lm20dk/nrf54lm20b/cpuapp -- -DSB_CONFIG_WIFI_NRF70=y -Dbridge_SHIELD=nrf7002eb2 -DCONFIG_BRIDGED_DEVICE_BT=y -DEXTRA_CONF_FILE="bt_max_connections_app.conf"
514514
515515
.. group-tab:: Matter bridge over Thread
516516

docs/includes/configuration/advanced/internal_memory.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ Internal memory only
3131

3232
.. group-tab:: |nRFVSC|
3333

34-
Add ``-DCONFIG_CHIP_DFU_OVER_BT_SMP=y -DFILE_SUFFIX=internal -D<sample_name>_EXTRA_CONF_FILE=prj_release.conf`` to :guilabel:`Extra CMake arguments` in your build configuration, replacing ``<sample_name>`` with the actual |matter_type| name (for example ``light_bulb`` or ``matter_bridge``).
34+
Add ``-DCONFIG_CHIP_DFU_OVER_BT_SMP=y -DFILE_SUFFIX=internal -D<sample_name>_EXTRA_CONF_FILE=prj_release.conf`` to :guilabel:`Extra CMake arguments` in your build configuration, replacing ``<sample_name>`` with the actual |matter_type| directory name (for example ``light_bulb`` or ``bridge``).
3535

3636
.. group-tab:: Command line
3737

samples/bridge/sample.yaml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ tests:
2828
- FILE_SUFFIX=release
2929
- CONFIG_BRIDGE_GENERIC_SWITCH_BRIDGED_DEVICE=n
3030
- CONFIG_BRIDGE_ONOFF_LIGHT_SWITCH_BRIDGED_DEVICE=y
31-
- matter_bridge_SHIELD=nrf7002eb2
31+
- bridge_SHIELD=nrf7002eb2
3232
- SB_CONFIG_WIFI_NRF70=y
3333
integration_platforms:
3434
- nrf54lm20dk/nrf54lm20b/cpuapp
@@ -56,7 +56,7 @@ tests:
5656
extra_args:
5757
- CONFIG_BRIDGE_GENERIC_SWITCH_BRIDGED_DEVICE=n
5858
- CONFIG_BRIDGE_ONOFF_LIGHT_SWITCH_BRIDGED_DEVICE=y
59-
- matter_bridge_SHIELD=nrf7002eb2
59+
- bridge_SHIELD=nrf7002eb2
6060
- SB_CONFIG_WIFI_NRF70=y
6161
integration_platforms:
6262
- nrf54lm20dk/nrf54lm20b/cpuapp
@@ -86,7 +86,7 @@ tests:
8686
- CONFIG_BRIDGED_DEVICE_BT=y
8787
- CONFIG_BRIDGE_GENERIC_SWITCH_BRIDGED_DEVICE=n
8888
- CONFIG_BRIDGE_ONOFF_LIGHT_SWITCH_BRIDGED_DEVICE=y
89-
- matter_bridge_SHIELD=nrf7002eb2
89+
- bridge_SHIELD=nrf7002eb2
9090
- SB_CONFIG_WIFI_NRF70=y
9191
integration_platforms:
9292
- nrf54lm20dk/nrf54lm20b/cpuapp
@@ -118,7 +118,7 @@ tests:
118118
- CONFIG_BRIDGED_DEVICE_BT=y
119119
- CONFIG_BRIDGE_GENERIC_SWITCH_BRIDGED_DEVICE=n
120120
- CONFIG_BRIDGE_ONOFF_LIGHT_SWITCH_BRIDGED_DEVICE=y
121-
- matter_bridge_SHIELD=nrf7002eb2
121+
- bridge_SHIELD=nrf7002eb2
122122
- SB_CONFIG_WIFI_NRF70=y
123123
integration_platforms:
124124
- nrf54lm20dk/nrf54lm20b/cpuapp
@@ -148,7 +148,7 @@ tests:
148148
- CONFIG_BRIDGED_DEVICE_BT=y
149149
- CONFIG_BRIDGE_GENERIC_SWITCH_BRIDGED_DEVICE=n
150150
- CONFIG_BRIDGE_ONOFF_LIGHT_SWITCH_BRIDGED_DEVICE=y
151-
- matter_bridge_SHIELD=nrf7002eb2
151+
- bridge_SHIELD=nrf7002eb2
152152
- SB_CONFIG_WIFI_NRF70=y
153153
integration_platforms:
154154
- nrf54lm20dk/nrf54lm20b/cpuapp

samples/weather_station/README.rst

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,15 +213,15 @@ Building for the nRF7002 Wi-Fi expansion board
213213

214214
.. group-tab:: |nRFVSC|
215215

216-
To build the application in the |nRFVSC| IDE for Thingy:53 with the nRF7002 EB attached, add ``-Dmatter_weather_station_SHIELD=nrf7002eb -DFILE_SUFFIX=release -DSB_CONFIG_WIFI_NRF70=y`` to :guilabel:`Extra CMake arguments` in your build configuration.
216+
To build the application in the |nRFVSC| IDE for Thingy:53 with the nRF7002 EB attached, add ``-Dweather_station_SHIELD=nrf7002eb -DFILE_SUFFIX=release -DSB_CONFIG_WIFI_NRF70=y`` to :guilabel:`Extra CMake arguments` in your build configuration.
217217

218218
.. group-tab:: Command line
219219

220220
To build the sample from the command line for Thingy:53 with the nRF7002 EB attached, use the following command within the sample directory:
221221

222222
.. code-block:: console
223223
224-
west build -b thingy53/nrf5340/cpuapp -- -Dmatter_weather_station_SHIELD=nrf7002eb -DFILE_SUFFIX=release -DSB_CONFIG_WIFI_NRF70=y
224+
west build -b thingy53/nrf5340/cpuapp -- -Dweather_station_SHIELD=nrf7002eb -DFILE_SUFFIX=release -DSB_CONFIG_WIFI_NRF70=y
225225
226226
Testing
227227
*******

0 commit comments

Comments
 (0)