app: Remove CONFIG_SM_AT_MAX_PARAM

CONFIG_SM_AT_MAX_PARAM (or CONFIG_SLM_AT_MAX_PARAM) is not useful
anymore after AT command parser and AT params libraries were replaced by
new AT parser library. This Kconfig was passed to at_params_list_init().
It was also used by some commands (#XNRFCLOUDPOS) for maximum number of
parameters but now those are only restricted by CONFIG_SM_AT_BUF_SIZE.

Signed-off-by: Tommi Rantanen <tommi.rantanen@nordicsemi.no>

Author: trantanen

app/Kconfig

@@ -13,10 +13,6 @@ config SM_CUSTOMER_VERSION
 	help
 	   This version is reported together with baseline versions by AT command "#XSMVER".
 
-config SM_AT_MAX_PARAM
-	int "Maximum number of parameters in AT command"
-	default 42
-
 config SM_AT_BUF_SIZE
 	int "AT command buffer size"
 	range 128 8192

app/src/sm_at_nrfcloud.c

@@ -55,15 +55,14 @@ static struct k_work nrfcloud_loc_req;
  * [,<n_earfcn>2, <n_phys_cell_id>2, <n_rsrp>2, <n_rsrq>2,<time_diff>2] ...
  * [,<n_earfcn>17, <n_phys_cell_id>17, <n_rsrp>17, <n_rsrq>17,<time_diff>17
  *
- * Max 17 ncell, but align with CONFIG_SM_AT_MAX_PARAM
+ * Max 17 ncell
  * 11 number of parameters for current cell (including "%NCELLMEAS")
  * 5  number of parameters for one neighboring cell
  */
 #define MAX_PARAM_CELL   11
 #define MAX_PARAM_NCELL  5
-/* Must support at least all params for current cell plus one ncell */
-#define NCELL_CNT ((CONFIG_SM_AT_MAX_PARAM - MAX_PARAM_CELL) / MAX_PARAM_NCELL)
-BUILD_ASSERT(NCELL_CNT > 0, "CONFIG_SM_AT_MAX_PARAM too small");
+/* Neighbor cells are not very useful for positioning so we don't need to support 10 or 17 */
+#define NCELL_CNT 5
 
 /* Neighboring cell measurements. */
 static struct lte_lc_ncell nrfcloud_ncells[NCELL_CNT];
@@ -76,8 +75,6 @@ static struct lte_lc_cells_info nrfcloud_cell_data = {
 static bool nrfcloud_ncellmeas_done;
 
 #define WIFI_APS_BEGIN_IDX 3
-BUILD_ASSERT(WIFI_APS_BEGIN_IDX + NRF_CLOUD_LOCATION_WIFI_AP_CNT_MIN
-	< CONFIG_SM_AT_MAX_PARAM, "CONFIG_SM_AT_MAX_PARAM too small");
 
 /* nRF Cloud location request Wi-Fi data. */
 static struct wifi_scan_info nrfcloud_wifi_data;
@@ -202,6 +199,12 @@ static void ncell_meas_mon(const char *notify)
 	for (unsigned int i = 0; i != ncells_count; ++i) {
 		const unsigned int offset = MAX_PARAM_CELL + i * MAX_PARAM_NCELL;
 
+		if (i >= NCELL_CNT) {
+			LOG_INF("Too many neighboring cells (%d) for allocated buffer (%d)",
+				i, NCELL_CNT);
+			break;
+		}
+
 		/* parse n_earfcn */
 		err = at_parser_num_get(&parser, offset, &nrfcloud_ncells[i].earfcn);
 		if (err < 0) {

doc/app/at_nrfcloud.rst

@@ -222,7 +222,7 @@ The ``<wifi_pos>`` parameter can have the following integer values:
 * ``0`` - Do not include Wi-Fi access point information in the location request.
 * ``1`` - Use Wi-Fi access point information.
   The access points must be given as additional parameters to the command.
-  The minimum number of access points to provide is two (``NRF_CLOUD_LOCATION_WIFI_AP_CNT_MIN``), and the maximum is limited by the AT command parameter count limit (:ref:`CONFIG_SM_AT_MAX_PARAM <CONFIG_SM_AT_MAX_PARAM>`).
+  The minimum number of access points to provide is two (``NRF_CLOUD_LOCATION_WIFI_AP_CNT_MIN``), and the maximum is limited by the AT command buffer size (:ref:`CONFIG_SM_AT_BUF_SIZE <CONFIG_SM_AT_BUF_SIZE>`).
 
 The ``<MAC x>`` parameter is a string.
 It indicates the MAC address of a Wi-Fi access point and must be formatted as ``%02x:%02x:%02x:%02x:%02x:%02x`` (``WIFI_MAC_ADDR_TEMPLATE``).

doc/app/sm_configuration.rst

@@ -20,11 +20,6 @@ CONFIG_SM_CUSTOMER_VERSION - Customer version string
    Version string defined by the customer after customizing the application.
    When defined, this version is reported with the baseline versions by the ``AT#XSMVER`` AT command.
 
-.. _CONFIG_SM_AT_MAX_PARAM:
-
-CONFIG_SM_AT_MAX_PARAM - AT command parameter count limit
-   This defines the maximum number of parameters allowed in an AT command, including the command name.
-
 .. _CONFIG_SM_AT_BUF_SIZE:
 
 CONFIG_SM_AT_BUF_SIZE - AT command buffer size

doc/migration_notes.rst

@@ -417,3 +417,5 @@ If you need any of those features with this |SM|, please contact customer suppor
     Use the ``CONFIG_SM_AUTO_CONNECT*`` Kconfig options to configure automatic network attach.
   * The ``CONFIG_SM_SKIP_READY_MSG`` Kconfig option.
     The ``Ready\r\n`` message is always sent when the |SM| application is ready to accept AT commands.
+  * The ``CONFIG_SM_AT_MAX_PARAM`` Kconfig option.
+    This Kconfig option has not been relevant in the latest versions of |NCS| SLM, as the AT parser library is now used.