Skip to content

Commit 7b16de9

Browse files
Apply suggestions from code review
Co-authored-by: Divya S Pillai <91891495+divipillai@users.noreply.github.com>
1 parent e49fae1 commit 7b16de9

2 files changed

Lines changed: 9 additions & 9 deletions

File tree

doc/app/PPP_AT_commands.rst

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ The set command allows you to start and stop PPP, and optionally define the PDN
3131

3232
.. note::
3333

34-
When PPP start has been issued, the PPP connection is automatically activated and deactivated when the PDN connection requested for PPP is established and lost, respectively.
35-
This will continue until PPP stop is issued.
34+
When a PPP start has been issued, the PPP connection is automatically activated and deactivated when the PDN connection requested for PPP is established and lost, respectively.
35+
This will continue until a PPP stop is issued.
3636

3737
Syntax
3838
~~~~~~
@@ -160,8 +160,8 @@ If you are using CMUX, see :ref:`sm_as_linux_modem` for more information on sett
160160

161161
For the process described here, |SM|'s UARTs must be connected to the Linux host.
162162

163-
1. Start PPP with ``AT#XPPP=1`` command.
164-
#. Set modem to online mode with ``AT+CFUN=1`` command.
163+
1. Start PPP with the ``AT#XPPP=1`` command.
164+
#. Set modem to online mode with the ``AT+CFUN=1`` command.
165165
#. Wait for ``#XPPP: 1,0,0``, which is sent when the network registration succeeds and PPP has started successfully with the default PDN connection.
166166
#. Run the following command on the Linux host:
167167

doc/migration_notes.rst

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,11 @@ The following changes are mandatory to make your application work in the same wa
5555
* Removed the ``AT#XPOLL`` command.
5656
Use ``AT#XAPOLL`` instead.
5757

58-
* PPP connection must be requested with ``AT#XPPP=1`` in order to get it started when modem is put to online mode with ``AT+CFUN=1``.
59-
``AT#XPPP=1`` can be done before or after ``AT+CFUN=1``.
60-
So PPP connection is not started automatically anymore when ``AT+CFUN=1`` is done.
61-
When ``AT#XPPP=1`` is done, the PPP connection is started when ``AT+CFUN=1`` is done and stopped when network is lost, for example with ``AT+CFUN=4`` or ``AT+CFUN=0``.
62-
When ``AT#XPPP=0`` is done, PPP connection is stopped permanently.
58+
* PPP connection must be requested using the ``AT#XPPP=1`` command to get it started when the modem is put into online mode using the ``AT+CFUN=1`` command.
59+
The ``AT#XPPP=1`` command can be run before or after the ``AT+CFUN=1`` command.
60+
So PPP connection is not started automatically anymore when the ``AT+CFUN=1`` command is run.
61+
After the ``AT#XPPP=1`` command is run, the PPP connection is started when the ``AT+CFUN=1`` command is run and stopped when network is lost (for example, with ``AT+CFUN=4`` or ``AT+CFUN=0``).
62+
When the ``AT#XPPP=0`` command is run, the PPP connection is stopped permanently.
6363

6464
DTR and RI GPIOs replace Power and Indicate pins
6565
------------------------------------------------

0 commit comments

Comments
 (0)