Skip to content

Commit b18c95a

Browse files
committed
app: Remove SKIP_READY option
Current nRF9151DK does not seem to have any problems with HWFC lines on board controller at boot, so disable the option. Ready is now always printed. Updated the Linux script to allow it, but ignore it. Signed-off-by: Seppo Takalo <seppo.takalo@nordicsemi.no>
1 parent 5f7cb82 commit b18c95a

6 files changed

Lines changed: 11 additions & 19 deletions

File tree

app/Kconfig

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,11 +24,6 @@ config SM_AT_BUF_SIZE
2424
help
2525
Size of the buffer for incoming AT commands and modem responses.
2626

27-
config SM_SKIP_READY_MSG
28-
bool "Skip ready message"
29-
help
30-
Skip sending the ready message when the application is powered on.
31-
3227
#
3328
# external XTAL for UART
3429
#

app/overlay-cmux.conf

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@
55
#
66

77
CONFIG_SM_CMUX=y
8-
CONFIG_SM_SKIP_READY_MSG=y
98

109
# Zephyr modem subsystem
1110
CONFIG_MODEM_MODULES=y

app/scripts/sm_start_ppp.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -170,7 +170,7 @@ trap cleanup ERR
170170
stty -F $MODEM $BAUD pass8 raw crtscts clocal
171171

172172
log_dbg "Wait modem to boot"
173-
if chat -t1 "" "AT" "OK" <$MODEM >$MODEM; then
173+
if chat -t1 "Ready--" "AT" "OK" <$MODEM >$MODEM; then
174174
log_dbg "Modem is in AT mode"
175175
else
176176
log_dbg "Modem not responding, try CMUX Close down..."

app/src/main.c

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -286,16 +286,14 @@ static int sm_main(void)
286286

287287
check_app_fota_status();
288288

289-
if (!IS_ENABLED(CONFIG_SM_SKIP_READY_MSG)) {
290-
if (sm_init_failed) {
291-
ret = sm_at_send_str(SM_SYNC_ERR_STR);
292-
} else {
293-
ret = sm_at_send_str(SM_SYNC_STR);
294-
}
289+
if (sm_init_failed) {
290+
ret = sm_at_send_str(SM_SYNC_ERR_STR);
291+
} else {
292+
ret = sm_at_send_str(SM_SYNC_STR);
293+
}
295294

296-
if (ret) {
297-
return ret;
298-
}
295+
if (ret) {
296+
return ret;
299297
}
300298

301299
/* This is here and not earlier because in case of firmware

app/src/sm_at_host.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1109,9 +1109,7 @@ int sm_at_host_power_off(void)
11091109
const int err = at_host_power_off(false);
11101110

11111111
/* Write sync str to buffer so it is sent first when resuming, do not flush. */
1112-
if (!IS_ENABLED(CONFIG_SM_SKIP_READY_MSG)) {
1113-
sm_tx_write(SM_SYNC_STR, strlen(SM_SYNC_STR), false, false);
1114-
}
1112+
sm_tx_write(SM_SYNC_STR, strlen(SM_SYNC_STR), false, false);
11151113

11161114
return err;
11171115
}

doc/migration_notes.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -415,3 +415,5 @@ If you need any of those features with this |SM|, please contact customer suppor
415415
Use the :file:`overlay-ppp.conf` and :file:`overlay-cmux.conf` files instead.
416416
* The :file:`sm_auto_connect.h` header file.
417417
Use the ``CONFIG_SM_AUTO_CONNECT*`` Kconfig options to configure automatic network attach.
418+
* The ``CONFIG_SM_SKIP_READY_MSG`` Kconfig option.
419+
The ``Ready\r\n`` message is always sent when the |SM| application is ready to accept AT commands.

0 commit comments

Comments
 (0)