Skip to content

Commit c1cfe66

Browse files
committed
app: Change CTS pull-down to pull-up
Previously CTS was pulled up, this prevented hosts without hardware flow control from using the default Serial Modem build. Changing CTS to pull-down allows Serial Modem to send even when the CTS and RTS pins float. This relies in DTR as main mechanism for UART control. The host must first enable its own UART before it enables Serial Modem UART with DTR. - With hardware flow control, this means that host drives it's RTS pin, so there is no difference in operation. Host should also have a pull-up for it's CTS pin, so when SM starts driving it's RTS, the host knows that SM is ready to receive. - Without hardware flow control, the Serial Modem is able to send (TX) to host. However, the timing with DTR and when SM is able to receive needs to be taken into account as host cannot observe it's CTS. Instead host must monitor the RI signal, which is de-asserted when SM UART is ready. Or alternatively, have a sufficient timeout between host asserting DTR and host's first TX operation. Important: It is highly recommended to use hardware flow control with Serial Modem. Signed-off-by: Markus Lassila <markus.lassila@nordicsemi.no>
1 parent 1ca70e7 commit c1cfe66

2 files changed

Lines changed: 37 additions & 2 deletions

File tree

app/boards/nrf9151dk_nrf9151_ns.overlay

Lines changed: 32 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,10 @@
2222
ri-gpios = <&gpio0 0 GPIO_ACTIVE_LOW>;
2323
status = "okay";
2424
};
25+
pinctrl-0 = <&uart0_default_alt>;
26+
pinctrl-1 = <&uart0_sleep_alt>;
27+
pinctrl-names = "default", "sleep";
28+
2529
};
2630

2731
&gpio0 {
@@ -30,6 +34,34 @@
3034
sense-edge-mask = <0x00000100>;
3135
};
3236

37+
38+
&pinctrl {
39+
uart0_default_alt: uart0_default_alt {
40+
group1 {
41+
psels = <NRF_PSEL(UART_RX, 0, 26)>;
42+
bias-pull-up;
43+
};
44+
group2 {
45+
psels = <NRF_PSEL(UART_CTS, 0, 15)>;
46+
bias-pull-down;
47+
};
48+
group3 {
49+
psels = <NRF_PSEL(UART_TX, 0, 27)>,
50+
<NRF_PSEL(UART_RTS, 0, 14)>;
51+
};
52+
};
53+
54+
uart0_sleep_alt: uart0_sleep_alt {
55+
group1 {
56+
psels = <NRF_PSEL(UART_TX, 0, 27)>,
57+
<NRF_PSEL(UART_RX, 0, 26)>,
58+
<NRF_PSEL(UART_RTS, 0, 14)>,
59+
<NRF_PSEL(UART_CTS, 0, 15)>;
60+
low-power-enable;
61+
};
62+
};
63+
};
64+
3365
/* Disable I2C2.
3466
* - Enabling IO expander causes ~20uA to be consumed while DTR is deasserted.
3567
* - We use P0.31 and P0.30 pins for DTR and RI signals with external MCU.

app/overlay-external-mcu.overlay

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,11 +45,14 @@
4545
&pinctrl {
4646
uart2_default_alt: uart2_default_alt {
4747
group1 {
48-
psels = <NRF_PSEL(UART_RX, 0, 3)>,
49-
<NRF_PSEL(UART_CTS, 0, 7)>;
48+
psels = <NRF_PSEL(UART_RX, 0, 3)>;
5049
bias-pull-up;
5150
};
5251
group2 {
52+
psels = <NRF_PSEL(UART_CTS, 0, 7)>;
53+
bias-pull-down;
54+
};
55+
group3 {
5356
psels = <NRF_PSEL(UART_TX, 0, 2)>,
5457
<NRF_PSEL(UART_RTS, 0, 6)>;
5558
};

0 commit comments

Comments
 (0)