[nrf toup] [nrfconnect] Fix missing returns error in WiFi Mgr

Fixed not checked return from several functions in WiFi Manager.

Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>

Author: ArekBalysNordic

src/platform/nrfconnect/wifi/NrfWiFiDriver.cpp

@@ -24,6 +24,7 @@
 #include <lib/support/CodeUtils.h>
 #include <lib/support/SafeInt.h>
 #include <lib/support/TypeTraits.h>
+#include <lib/support/logging/CHIPLogging.h>
 #include <platform/CHIPDeviceLayer.h>
 
 using namespace ::chip;
@@ -124,7 +125,11 @@ void NrfWiFiDriver::OnNetworkConnStatusChanged(const wifi_conn_status & connStat
 
     if (status == Status::kSuccess)
     {
-        ConnectivityMgr().SetWiFiStationMode(ConnectivityManager::kWiFiStationMode_Enabled);
+        CHIP_ERROR err = ConnectivityMgr().SetWiFiStationMode(ConnectivityManager::kWiFiStationMode_Enabled);
+        if (err != CHIP_NO_ERROR)
+        {
+            ChipLogError(DeviceLayer, "SetWiFiStationMode failed: %" CHIP_ERROR_FORMAT, err.Format());
+        }
     }
 
     if (mpNetworkStatusChangeCallback)
@@ -182,7 +187,7 @@ CHIP_ERROR NrfWiFiDriver::RevertConfiguration()
             return CHIP_NO_ERROR;
         }
 
-        WiFiManager::Instance().Disconnect();
+        ReturnErrorOnFailure(WiFiManager::Instance().Disconnect());
     }
 
     if (mStagingNetwork.IsConfigured())
@@ -254,7 +259,10 @@ void NrfWiFiDriver::ConnectNetwork(ByteSpan networkId, ConnectCallback * callbac
                  status = Status::kOtherConnectionFailure);
     VerifyOrExit(networkId.data_equal(mStagingNetwork.GetSsidSpan()), status = Status::kNetworkIDNotFound);
 
-    WiFiManager::Instance().Connect(mStagingNetwork.GetSsidSpan(), mStagingNetwork.GetPassSpan(), handling);
+    {
+        CHIP_ERROR err = WiFiManager::Instance().Connect(mStagingNetwork.GetSsidSpan(), mStagingNetwork.GetPassSpan(), handling);
+        VerifyOrExit(err == CHIP_NO_ERROR, status = Status::kUnknownError);
+    }
 
 exit:
     if (status != Status::kSuccess && mpConnectCallback)

src/platform/nrfconnect/wifi/WiFiManager.cpp

@@ -184,7 +184,7 @@ void WiFiManager::SuppEventHandler(net_mgmt_event_callback * cb, uint64_t mgmtEv
 {
     if (mgmtEvent == NET_EVENT_SUPPLICANT_NOT_READY)
     {
-        SystemLayer().ScheduleLambda([] {
+        SystemLayer().ScheduleLambda([]() -> void {
             if (Instance().mWiFiState == WIFI_STATE_COMPLETED)
             {
                 Instance().mReconnect = true;
@@ -194,12 +194,21 @@ void WiFiManager::SuppEventHandler(net_mgmt_event_callback * cb, uint64_t mgmtEv
     }
     else if (mgmtEvent == NET_EVENT_SUPPLICANT_READY)
     {
-        SystemLayer().ScheduleLambda([] {
+        SystemLayer().ScheduleLambda([]() -> void {
             if (Instance().mWantedNetwork.IsConfigured() && Instance().mReconnect)
             {
                 Instance().mReconnect = false;
-                Instance().SetLowPowerMode(Instance().mWiFiPsEnabled);
-                Instance().Scan(Instance().mWantedNetwork.GetSsidSpan(), nullptr, nullptr, true /* internal scan */);
+                CHIP_ERROR err        = Instance().SetLowPowerMode(Instance().mWiFiPsEnabled);
+                if (err != CHIP_NO_ERROR)
+                {
+                    ChipLogError(DeviceLayer, "SetLowPowerMode failed: %" CHIP_ERROR_FORMAT, err.Format());
+                }
+                CHIP_ERROR scanErr =
+                    Instance().Scan(Instance().mWantedNetwork.GetSsidSpan(), nullptr, nullptr, true /* internal scan */);
+                if (scanErr != CHIP_NO_ERROR)
+                {
+                    ChipLogError(DeviceLayer, "WiFi recovery scan failed: %" CHIP_ERROR_FORMAT, scanErr.Format());
+                }
             }
         });
     }
@@ -366,7 +375,7 @@ void WiFiManager::ScanResultHandler(Platform::UniquePtr<uint8_t> data, size_t le
         // In case there are many networks with the same SSID choose the one with the best RSSI
         if (scanResult->rssi > Instance().mWiFiParams.mRssi)
         {
-            Instance().ClearStationProvisioningData();
+            TEMPORARY_RETURN_IGNORED Instance().ClearStationProvisioningData();
             Instance().mWiFiParams.mParams.ssid_length = static_cast<uint8_t>(Instance().mWantedNetwork.ssidLen);
             Instance().mWiFiParams.mParams.ssid        = Instance().mWantedNetwork.ssid;
             // Fallback to the WIFI_SECURITY_TYPE_PSK if the security is unknown
@@ -488,7 +497,7 @@ void WiFiManager::ConnectHandler(Platform::UniquePtr<uint8_t> data, size_t lengt
     // Validate that input data size matches the expected one.
     VerifyOrReturn(length == sizeof(wifi_status));
 
-    CHIP_ERROR err = SystemLayer().ScheduleLambda([capturedData = data.get()] {
+    CHIP_ERROR err = SystemLayer().ScheduleLambda([capturedData = data.get()]() -> void {
         Platform::UniquePtr<uint8_t> safePtr(capturedData);
         uint8_t * rawData           = safePtr.get();
         const wifi_status * status  = reinterpret_cast<const wifi_status *>(rawData);
@@ -564,7 +573,11 @@ void WiFiManager::ConnectHandler(Platform::UniquePtr<uint8_t> data, size_t lengt
             }
         }
         // cleanup the provisioning data as it is configured per each connect request
-        Instance().ClearStationProvisioningData();
+        CHIP_ERROR clearErr = Instance().ClearStationProvisioningData();
+        if (clearErr != CHIP_NO_ERROR)
+        {
+            ChipLogError(DeviceLayer, "ClearStationProvisioningData failed: %" CHIP_ERROR_FORMAT, clearErr.Format());
+        }
     });
 
     if (CHIP_NO_ERROR == err)
@@ -678,7 +691,11 @@ void WiFiManager::Recover(System::Layer *, void *)
         return;
     }
 
-    Instance().Scan(Instance().mWantedNetwork.GetSsidSpan(), nullptr, nullptr, true /* internal scan */);
+    CHIP_ERROR scanErr = Instance().Scan(Instance().mWantedNetwork.GetSsidSpan(), nullptr, nullptr, true /* internal scan */);
+    if (scanErr != CHIP_NO_ERROR)
+    {
+        ChipLogError(DeviceLayer, "Connection recovery scan failed: %" CHIP_ERROR_FORMAT, scanErr.Format());
+    }
 }
 
 void WiFiManager::ResetRecoveryTime()