Skip to content

Commit b1a600e

Browse files
[nrf toup][nrfconnect] Added missing GetSoftwareVersionString impl
The basic information cluster implementation started to use DeviceInfoProvider instead of ConfigurationMgr. Because of that GetSoftwareVersionString returns not implemented error code, as nrfconnect provider does not override this method. Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>
1 parent b155d47 commit b1a600e

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

src/platform/nrfconnect/FactoryDataProvider.cpp

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818
#include "FactoryDataProvider.h"
1919
#include "CHIPDevicePlatformConfig.h"
2020
#include <crypto/CHIPCryptoPAL.h>
21+
#include <platform/ConfigurationManager.h>
2122

2223
#ifdef CONFIG_CHIP_CERTIFICATION_DECLARATION_STORAGE
2324
#include <credentials/CertificationDeclaration.h>
@@ -506,6 +507,11 @@ CHIP_ERROR FactoryDataProvider<FlashFactoryData>::GetProductPrimaryColor(app::Cl
506507
return CHIP_NO_ERROR;
507508
}
508509

510+
template <class FlashFactoryData>
511+
CHIP_ERROR FactoryDataProvider<FlashFactoryData>::GetSoftwareVersionString(char * buf, size_t bufSize){
512+
return ConfigurationMgr().GetSoftwareVersionString(buf, bufSize);
513+
}
514+
509515
template <class FlashFactoryData>
510516
CHIP_ERROR FactoryDataProvider<FlashFactoryData>::GetUserData(MutableByteSpan & userData)
511517
{

src/platform/nrfconnect/FactoryDataProvider.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -218,7 +218,7 @@ class FactoryDataProvider : public FactoryDataProviderBase
218218
CHIP_ERROR GetRotatingDeviceIdUniqueId(MutableByteSpan & uniqueIdSpan) override;
219219
CHIP_ERROR GetProductFinish(app::Clusters::BasicInformation::ProductFinishEnum * finish) override;
220220
CHIP_ERROR GetProductPrimaryColor(app::Clusters::BasicInformation::ColorEnum * primaryColor) override;
221-
221+
CHIP_ERROR GetSoftwareVersionString(char * buf, size_t bufSize) override;
222222
// ===== Members functions that are platform-specific
223223
CHIP_ERROR GetEnableKey(MutableByteSpan & enableKey) override;
224224
CHIP_ERROR GetUserData(MutableByteSpan & userData) override;

0 commit comments

Comments
 (0)