[nrf noup] [west zap-*] Apply copilot suggestions

- Refined error handling
- Reduced the verbosity

Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no>

Author: markaj-nordic

scripts/west/zap_append.py

@@ -12,7 +12,7 @@
 from zap_common import DEFAULT_MATTER_PATH, DEFAULT_MATTER_TYPES_RELATIVE_PATH, DEFAULT_ZCL_JSON_RELATIVE_PATH
 
 
-def get_attribute_name(attribute: ET.Element) -> str | None:
+def get_attribute_name(attribute: ET.Element) -> str:
     """If attribute has a name, return it, otherwise fallback to the text of the attribute entry."""
     from_attr = attribute.get('name')
     if from_attr:

scripts/west/zap_common.py

@@ -301,7 +301,12 @@ def display_zap_message(output: subprocess.CompletedProcess[str]) -> None:
     """
     If the output contains the error from napi_throw, suggest user to use zap-sync to sync the ZAP file and make sure that all attributes are provided.
     """
-    print(f"output: {output.stdout}")
+    if output.stdout:
+        log.dbg(f"output: {output.stdout}")
+
+    if output.stderr:
+        log.wrn(f"stderr: {output.stderr}")
+
     if 'Unknown attribute' in output.stdout:
         log.err("Your zcl.json file seems to be outdated or is missing some attributes. "
                 "Please use 'west zap-sync' command to synchronize it with the newest Matter Data Model "

scripts/west/zap_gui.py

@@ -104,7 +104,7 @@ def run_zap():
                 output = subprocess.run([str(x) for x in cmd], capture_output=True, text=True)
                 # Chromium often prints nothing to stdout when the sandbox aborts early.
                 # returncode -5 is a sentinel consumed by fix_sandbox_permissions().
-                if not output.stdout:
+                if output.returncode != 0 and not output.stdout and not output.stderr:
                     raise subprocess.CalledProcessError(-5, cmd)
                 display_zap_message(output)
                 return output

scripts/west/zap_sync.py

@@ -97,7 +97,7 @@ def run_zap():
             output = subprocess.run([str(x) for x in cmd], capture_output=True, text=True)
             # Chromium often prints nothing to stdout when the sandbox aborts early.
             # returncode -5 is a sentinel consumed by fix_sandbox_permissions().
-            if not output.stdout:
+            if output.returncode != 0 and not output.stdout and not output.stderr:
                 raise subprocess.CalledProcessError(-5, cmd)
             display_zap_message(output)
             return output