Skip to content

Fix Partition Manager dependency#682

Merged
ArekBalysNordic merged 1 commit into
nrfconnect:masterfrom
ArekBalysNordic:remove_pm
Apr 27, 2026
Merged

Fix Partition Manager dependency#682
ArekBalysNordic merged 1 commit into
nrfconnect:masterfrom
ArekBalysNordic:remove_pm

Conversation

@ArekBalysNordic
Copy link
Copy Markdown
Contributor

@ArekBalysNordic ArekBalysNordic commented Nov 27, 2025

  • Removed obsolete CMake files that are not used anywhere.
  • Fixed dependency on factory data partition when the Partition Manager is not enabled.
  • Fixed kSettingsBlockEnd when Partition Manager is not enabled.

Testing

In NCS

NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Nov 27, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-connectedhomeip#682

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Dec 2, 2025

CLA assistant check
All committers have signed the CLA.

NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 2, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-connectedhomeip#682

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 8, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-connectedhomeip#682

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 9, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-connectedhomeip#682

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Dec 10, 2025
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-connectedhomeip#682

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Jan 5, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-connectedhomeip#682

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
@ArekBalysNordic
Copy link
Copy Markdown
Contributor Author

rebased

NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Jan 5, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-connectedhomeip#682

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Jan 15, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-connectedhomeip#682

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
@ArekBalysNordic ArekBalysNordic marked this pull request as ready for review January 30, 2026 09:32
@ArekBalysNordic ArekBalysNordic requested a review from a team as a code owner January 30, 2026 09:32
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Feb 9, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-connectedhomeip#682

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Feb 12, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-connectedhomeip#682

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Feb 18, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-connectedhomeip#682

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Apr 10, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-connectedhomeip#682

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Apr 15, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-connectedhomeip#682

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
- There should not be dependency to the Partition Manager if it is
not enabled.

- Fix wrongly referring to partitions as alises

- To properly resolve `@{ZEPHYR_NRF_MODULE_DIR}` we need to use
string(CONFIGURE ...) on it.

- Add Kconfig to set the proper CHIP_APP_ZAP_DIR if the
custom location of the zap-generated files is used.

- Fix Factory Data to put files in the correct place and run
with the correct configuration

Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
Co-authored-by: Jamie McCrae <jamie.mccrae@nordicsemi.no>
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Apr 16, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-connectedhomeip#682

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
@ArekBalysNordic ArekBalysNordic merged commit 68fb1e3 into nrfconnect:master Apr 27, 2026
12 checks passed
NordicBuilder added a commit to NordicBuilder/sdk-nrf that referenced this pull request Apr 27, 2026
Automatically created by action-manifest-pr GH action from PR:
nrfconnect/sdk-connectedhomeip#682

Signed-off-by: Nordic Builder <pylon@nordicsemi.no>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants