NCSDK-35199: Remove magic numbers #542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchy
changed the title
tomchy
force-pushed
the
bugfix/mcuboot/NCSDK-35199_Remove_magic_numbers
branch
from
d86fef5 to
804b6fc
Compare
tomchy
force-pushed
the
bugfix/mcuboot/NCSDK-35199_Remove_magic_numbers
branch
2 times, most recently
from
25eadfa to
330d5e6
Compare
nordicjm
approved these changes
Sep 30, 2025
de-nordic
approved these changes
Sep 30, 2025
Use the dedicated type to specify the slot number. Signed-off-by: Tomasz Chyrowicz <[email protected]> (cherry picked from commit d5b0dcb9aaee397fc105ae2228e8030038c3d871)
nrf-squash! [nrf noup] bootloader: Add bootloader requests Change bootloader request module, so it uses the new, dedicated type to point to the specific slot. Ref: NCSDK-35199 Signed-off-by: Tomasz Chyrowicz <[email protected]>
tomchy
force-pushed
the
bugfix/mcuboot/NCSDK-35199_Remove_magic_numbers
branch
from
330d5e6 to
83d224a
Compare
|
nvlsianpu
approved these changes
Sep 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.