samples: ble_nus_central: cleanup sample

* Update header include list. Add missing and reorder.
* Update return type of scan_start function to void because the
  returned error values are not used.
* Align the placement of const keyword for some parameters and
  variables.
* Align names some event handlers and init functions.
* Align setup of scan filters with other central samples.
* Removed call to ble_nus_client_handles_assign from
  BLE_GAP_EVT_CONNECTED evt handling (it is done from
  BLE_NUS_CLIENT_EVT_DISCOVERY_COMPLETE event handling) and
  moved a call to scan_start() from BLE_NUS_CLIENT_EVT_DISCONNECTED
  event handling to BLE_GAP_EVT_DISCONNECTED event handling to align
  with ble_hrs_central sample.
* Removed application specific handling of the
  BLE_GAP_EVT_PHY_UPDATE_REQUEST event. It is now handled by
  the conn_params library.
* Removed some duplicate logging of ATT MTU and data length updates.

Signed-off-by: Andreas Moltumyr <andreas.moltumyr@nordicsemi.no>

Author: anhmolt

samples/bluetooth/ble_nus_central/Kconfig

@@ -4,7 +4,7 @@
 # SPDX-License-Identifier: LicenseRef-Nordic-5-Clause
 #
 
-menu "BLE NUS Central sample"
+menu "Bluetooth LE NUS central sample"
 
 config SAMPLE_BLE_DEVICE_NAME
 	string "Device name"
@@ -27,13 +27,13 @@ config SAMPLE_NUS_CENTRAL_UART_RX_BUF_SIZE
 	help
 	  UART RX is double buffered, so the actual buffer will be twice as large.
 
+config SAMPLE_NUS_CENTRAL_LPUARTE
+	bool "NUS Client Low Power UARTE"
+
 config SAMPLE_USE_TARGET_PERIPHERAL_NAME
 	bool "Use target peripheral name"
 	default y
 
-config SAMPLE_NUS_CENTRAL_LPUARTE
-	bool "NUS Client Low Power UARTE"
-
 if SAMPLE_USE_TARGET_PERIPHERAL_NAME
 
 config SAMPLE_TARGET_PERIPHERAL_NAME

samples/bluetooth/ble_nus_central/README.rst

@@ -44,21 +44,21 @@ In addition, the sample enables peer TX notifications to receive data from the p
 User interface
 **************
 
+Button 3:
+   Press to disconnect from the connected peer device.
+
 LED 0:
-  Lit when the device is initialized.
+   Lit when the device is initialized.
 
 LED 1:
-  Lit when a device is connected.
-
-Button 3:
-  Disconnects from the peer when pressed.
+   Lit when a device is connected.
 
 .. note::
 
-  LEDs are only used in the normal UARTE configuration.
-  In LPUARTE mode, LEDs are disabled to avoid interfering with the RX pin and to allow proper low-power operation.
+   LEDs are only used in the normal UARTE configuration.
+   In LPUARTE mode, LEDs are disabled to avoid interfering with the RX pin and to allow proper low-power operation.
 
-  In LPUARTE mode, **LED 1** may appear lit even when no device is connected for some development kits, because it shares a pin with the RX signal; RX activity can toggle the LED, which is expected behavior.
+   In LPUARTE mode, **LED 1** may appear lit even when no device is connected for some development kits, because it shares a pin with the RX signal; RX activity can toggle the LED, which is expected behavior.
 
 
 Building and running
@@ -94,12 +94,12 @@ You can test the sample in two ways, depending on the selected UART configuratio
       #. Connect to the kit with a terminal emulator (for example, the `Serial Terminal app`_) for both UARTs on both development kits.
       #. Reset the kits.
       #. Observe that the device running the :ref:`ble_nus_central_sample` sample is configured to connect to ``nRF_BM_NUS``.
-         You can configure this name using the :kconfig:option:`SAMPLE_TARGET_PERIPHERAL_NAME` Kconfig option.
+         You can configure this name using the :kconfig:option:`CONFIG_SAMPLE_TARGET_PERIPHERAL_NAME` Kconfig option.
          For information on how to do this, see `Configuring Kconfig`_.
       #. Observe that the device running the :ref:`ble_nus_sample` sample is advertising under the default name ``nRF_BM_NUS``.
          You can configure this name using the :kconfig:option:`CONFIG_SAMPLE_BLE_DEVICE_NAME` Kconfig option.
          For information on how to do this, see `Configuring Kconfig`_.
-      #. Observe that the text ``BLE NUS central example started.`` is printed on the COM listener connected to the device running the :ref:`ble_nus_central_sample` sample.
+      #. Observe that the text ``BLE NUS central sample initialized`` is printed on the COM listener connected to the device running the :ref:`ble_nus_central_sample` sample.
       #. Observe that the text ``BLE NUS sample initialized`` is printed on the COM listener connected to the device running the :ref:`ble_nus_sample` sample.
       #. Write a text in the COM listener running on the computer and press Enter.
       #. Observe that the text is displayed in the second COM listener running on the computer.