applications, samples: do not set sys attrs from connected event

Wait for the SoftDevice to send the BLE_GATTS_EVT_SYS_ATTR_MISSING
event before setting the GATTS system attributes with
sd_ble_gatts_sys_attr_set().

It is not illegal or wrong to set it on a connection event, but
it duplicates some code and it overcomplicates the samples a bit.

Signed-off-by: Andreas Moltumyr <andreas.moltumyr@nordicsemi.no>

Author: anhmolt

applications/firmware_loader/ble_mcumgr/src/main.c

@@ -66,11 +66,6 @@ static void on_ble_evt(const ble_evt_t *evt, void *ctx)
 	{
 		LOG_INF("Peer connected");
 		conn_handle = evt->evt.gap_evt.conn_handle;
-		nrf_err = sd_ble_gatts_sys_attr_set(evt->evt.gap_evt.conn_handle, NULL, 0, 0);
-
-		if (nrf_err) {
-			LOG_ERR("Failed to set system attributes, nrf_error %#x", nrf_err);
-		}
 		break;
 	}
 

doc/nrf-bm/release_notes/release_notes_changelog.rst

@@ -110,6 +110,13 @@ Peripheral samples
 Bluetooth LE samples
 --------------------
 
+* Updated the following samples and applications that do not support pairing to call the :c:func:`sd_ble_gatts_sys_attr_set` function only in response to the :c:macro:`BLE_GATTS_EVT_SYS_ATTR_MISSING` event and not as a response to a :c:macro:`BLE_GAP_EVT_CONNECTED` event:
+
+   * :ref:`ug_dfu_firmware_loader` (Bluetooth LE)
+   * :ref:`ble_lbs_sample`
+   * :ref:`ble_nus_sample`
+   * :ref:`ble_mcuboot_recovery_entry_sample`
+
 * :ref:`ble_cgms_sample` sample:
 
    * Removed the call to the :c:func:`sd_ble_gatts_sys_attr_set` function from the main source file.

samples/bluetooth/ble_lbs/src/main.c

@@ -37,10 +37,6 @@ static void on_ble_evt(const ble_evt_t *evt, void *ctx)
 	case BLE_GAP_EVT_CONNECTED:
 		LOG_INF("Peer connected");
 		conn_handle = evt->evt.gap_evt.conn_handle;
-		nrf_err = sd_ble_gatts_sys_attr_set(conn_handle, NULL, 0, 0);
-		if (nrf_err) {
-			LOG_ERR("Failed to set system attributes, nrf_error %#x", nrf_err);
-		}
 		nrf_gpio_pin_write(BOARD_PIN_LED_1, BOARD_LED_ACTIVE_STATE);
 		break;
 

samples/bluetooth/ble_nus/src/main.c

@@ -201,10 +201,6 @@ static void on_ble_evt(const ble_evt_t *evt, void *ctx)
 		LOG_INF("Peer connected");
 		ble_nus_max_data_len = BLE_NUS_MAX_DATA_LEN_CALC(BLE_GATT_ATT_MTU_DEFAULT);
 		conn_handle = evt->evt.gap_evt.conn_handle;
-		nrf_err = sd_ble_gatts_sys_attr_set(conn_handle, NULL, 0, 0);
-		if (nrf_err) {
-			LOG_ERR("Failed to set system attributes, nrf_error %#x", nrf_err);
-		}
 
 		nrf_err = ble_qwr_conn_handle_assign(&ble_qwr, conn_handle);
 		if (nrf_err) {

samples/boot/mcuboot_recovery_entry/src/main.c

@@ -58,11 +58,6 @@ static void on_ble_evt(const ble_evt_t *evt, void *ctx)
 	{
 		LOG_INF("Peer connected");
 		conn_handle = evt->evt.gap_evt.conn_handle;
-		nrf_err = sd_ble_gatts_sys_attr_set(evt->evt.gap_evt.conn_handle, NULL, 0, 0);
-
-		if (nrf_err) {
-			LOG_ERR("Failed to set system attributes, nrf_error %#x", nrf_err);
-		}
 		break;
 	}