tests: unit: peer_manager: add peer manager unit tests

Add first set of unit tests for peer manager library.

Signed-off-by: Andreas Moltumyr <andreas.moltumyr@nordicsemi.no>

Author: anhmolt

lib/bluetooth/peer_manager/modules/peer_data_storage.c

@@ -179,7 +179,7 @@ static void peer_ids_load(void)
 
 	peer_data.all_data = peer_data_buffer;
 
-	/* Search through existing bonds to look for a duplicate. */
+	/* Allocate peer IDs for already stored bonds. */
 	pds_peer_data_iterate_prepare(&peer_id_iter);
 
 	while (pds_peer_data_iterate(PM_PEER_DATA_ID_BONDING, &peer_id, &peer_data,
@@ -282,7 +282,9 @@ static void bm_zms_evt_handler(const struct bm_zms_evt *evt)
 static void wait_for_init(void)
 {
 	while (!fs.init_flags.initialized) {
+#if !defined(CONFIG_UNITY)
 		k_cpu_idle();
+#endif
 	}
 }
 

lib/bluetooth/peer_manager/modules/peer_id.c

@@ -9,7 +9,9 @@
 #include <string.h>
 #include <limits.h>
 #include <zephyr/sys/atomic.h>
-#include <nrf_bitmask.h>
+#if !defined(CONFIG_UNITY)
+#include <nrfx.h>
+#endif
 #include <bm/bluetooth/peer_manager/peer_manager_types.h>
 #include <modules/peer_id.h>
 
@@ -40,7 +42,11 @@ static uint32_t find_and_set_flag(atomic_t *pi_flags, uint32_t flag_count)
 
 		while (inverted) {
 			/* Find lowest zero bit */
+#if defined(CONFIG_UNITY)
+			uint32_t first_zero = __builtin_ctz(inverted);
+#else
 			uint32_t first_zero = NRF_CTZ(inverted);
+#endif
 			uint32_t first_zero_global = first_zero + (i * 32);
 
 			if (first_zero_global >= flag_count) {

lib/bluetooth/peer_manager/modules/security_manager.c

@@ -406,7 +406,7 @@ static void sec_req_process(const struct pm_evt *event)
 	(void)link_secure(event->conn_handle, null_params, force_repairing, true);
 	/* The error code has been properly handled inside link_secure(). */
 }
-#endif
+#endif /* CONFIG_SOFTDEVICE_CENTRAL */
 
 /**
  * @brief Function for translating an SMD event to an SM event and passing it on to SM event
@@ -434,7 +434,7 @@ void sm_smd_evt_handler(struct pm_evt *event)
 	case PM_EVT_PERIPHERAL_SECURITY_REQ:
 #if defined(CONFIG_SOFTDEVICE_CENTRAL)
 		sec_req_process(event);
-#endif
+#endif /* CONFIG_SOFTDEVICE_CENTRAL */
 		/* fallthrough */
 	default:
 		/* Forward the event to all registered Security Manager event handlers. */
@@ -518,6 +518,9 @@ uint32_t sm_init(void)
 		return NRF_ERROR_INTERNAL;
 	}
 
+	default_sec_params = NULL;
+	default_sec_params_set = false;
+
 	module_initialized = true;
 
 	return NRF_SUCCESS;

lib/bluetooth/peer_manager/peer_manager.c

@@ -389,6 +389,10 @@ uint32_t pm_register(pm_evt_handler_t event_handler)
 		return NRF_ERROR_INVALID_STATE;
 	}
 
+	if (!event_handler) {
+		return NRF_ERROR_NULL;
+	}
+
 	if (n_registrants >= CONFIG_PM_MAX_REGISTRANTS) {
 		return NRF_ERROR_NO_MEM;
 	}

subsys/softdevice_handler/nrf_sdh_ble.c

@@ -62,7 +62,7 @@ const char *nrf_sdh_ble_evt_to_str(uint32_t evt)
 		return "BLE_GAP_EVT_SEC_REQUEST";
 	case BLE_GAP_EVT_CONN_PARAM_UPDATE_REQUEST:
 		return "BLE_GAP_EVT_CONN_PARAM_UPDATE_REQUEST";
-#endif
+#endif /* CONFIG_SOFTDEVICE_CENTRAL */
 	case BLE_GAP_EVT_SCAN_REQ_REPORT:
 		return "BLE_GAP_EVT_SCAN_REQ_REPORT";
 	case BLE_GAP_EVT_PHY_UPDATE_REQUEST:
@@ -175,13 +175,13 @@ static int default_cfg_set(void)
 		ble_cfg.gap_cfg.role_count_cfg.adv_set_count = BLE_GAP_ADV_SET_COUNT_DEFAULT;
 #endif
 
-#if CONFIG_SOFTDEVICE_CENTRAL
+#if defined(CONFIG_SOFTDEVICE_CENTRAL)
 		ble_cfg.gap_cfg.role_count_cfg.central_role_count =
 			CONFIG_NRF_SDH_BLE_CENTRAL_LINK_COUNT;
 		ble_cfg.gap_cfg.role_count_cfg.central_sec_count =
 			MIN(CONFIG_NRF_SDH_BLE_CENTRAL_LINK_COUNT,
 			    BLE_GAP_ROLE_COUNT_CENTRAL_SEC_DEFAULT);
-#endif
+#endif /* CONFIG_SOFTDEVICE_CENTRAL */
 
 	err = sd_ble_cfg_set(BLE_GAP_CFG_ROLE_COUNT, &ble_cfg, app_ram_start);
 	if (err) {

tests/unit/lib/bluetooth/peer_manager/CMakeLists.txt

@@ -0,0 +1,35 @@
+#
+# Copyright (c) 2025 Nordic Semiconductor ASA
+#
+# SPDX-License-Identifier: LicenseRef-Nordic-5-Clause
+#
+
+cmake_minimum_required(VERSION 3.20.0)
+
+find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
+
+project(unit_test_peer_manager)
+
+include(${ZEPHYR_NRF_BM_MODULE_DIR}/cmake/unity/unity_softdevice_setup.cmake)
+unity_softdevice_header_setup(VARIANT "s145")
+unity_softdevice_event_setup()
+
+cmock_handle(${SOFTDEVICE_INCLUDE_DIR}/ble_gap.h)
+cmock_handle(${SOFTDEVICE_INCLUDE_DIR}/ble_gattc.h)
+cmock_handle(${SOFTDEVICE_INCLUDE_DIR}/ble_gatts.h)
+cmock_handle(${SOFTDEVICE_INCLUDE_DIR}/nrf_soc.h)
+cmock_handle(${ZEPHYR_NRF_BM_MODULE_DIR}/include/bm/bm_timer.h)
+cmock_handle(${ZEPHYR_NRF_BM_MODULE_DIR}/include/bm/fs/bm_zms.h)
+cmock_handle(${ZEPHYR_NRF_BM_MODULE_DIR}/include/bm/softdevice_handler/nrf_sdh_ble.h)
+cmock_handle(include/psa/crypto.h) # Local definitions for mocking of psa/crypto.h with CMock
+
+# Increase the memory size for CMock. The default of 32768 is not sufficient for the tests.
+zephyr_compile_definitions(CMOCK_MEM_SIZE=65536)
+
+zephyr_include_directories(
+  ${CMAKE_CURRENT_SOURCE_DIR}/include # Include test specific headers
+)
+
+# Generate and add test file
+test_runner_generate(src/unity_test.c)
+target_sources(app PRIVATE src/unity_test.c)

tests/unit/lib/bluetooth/peer_manager/Kconfig

@@ -0,0 +1,26 @@
+# Clear dependencies for PEER_MANAGER, PM_SERVICE_CHANGED, and PM_LESC,
+# then enable them to allow testing the features.
+config PEER_MANAGER
+	default y
+
+config PM_SERVICE_CHANGED
+	default y
+
+config PM_LESC
+	default y
+
+# Redefine Kconfigs used by the tested module that is defined in
+# other modules we do not want to enable.
+config NRF_SDH_BLE_TOTAL_LINK_COUNT
+	default 2
+
+config SOFTDEVICE_PERIPHERAL
+	default y
+
+config SOFTDEVICE_CENTRAL
+	default y
+
+config BM_STORAGE_BACKEND_SD
+	default y
+
+source "Kconfig.zephyr"

tests/unit/lib/bluetooth/peer_manager/boards/native_sim.overlay

@@ -0,0 +1,4 @@
+/* Mock values for PEER_MANAGER_NODE, PEER_MANAGER_PARTITION_OFFSET and
+ * PEER_MANAGER_PARTITION_SIZE in peer manger file peer_data_storage.c.
+ */
+peer_manager_partition: &storage_partition {};

tests/unit/lib/bluetooth/peer_manager/include/psa/crypto.h

@@ -0,0 +1,57 @@
+/*
+ * Copyright (c) 2025 Nordic Semiconductor ASA
+ *
+ * SPDX-License-Identifier: LicenseRef-Nordic-5-Clause
+ */
+
+#ifndef PSA_CRYPTO_FOR_MOCKING_H__
+#define PSA_CRYPTO_FOR_MOCKING_H__
+
+#include <stddef.h>
+#include <stdint.h>
+
+/* Header for mocking the required psa/crypto.h functionality with CMock.
+ * For use in nrf_ble_lesc unit tests.
+ */
+
+typedef uint32_t psa_key_id_t;
+typedef psa_key_id_t mbedtls_svc_key_id_t;
+typedef int32_t psa_status_t;
+typedef uint16_t psa_key_type_t;
+
+typedef int psa_key_attributes_t;
+typedef uint32_t psa_key_usage_t;
+typedef uint32_t psa_key_lifetime_t;
+typedef uint32_t psa_algorithm_t;
+typedef uint8_t psa_ecc_family_t;
+
+#define PSA_KEY_ATTRIBUTES_INIT 0x00C0FFEE
+
+#define PSA_EXPORT_PUBLIC_KEY_OUTPUT_SIZE(key_type, key_bits) (65)
+#define PSA_KEY_TYPE_ECC_KEY_PAIR(curve) 0
+#define PSA_ECC_FAMILY_SECP_R1 ((psa_ecc_family_t)0x12)
+
+#define PSA_KEY_USAGE_DERIVE ((psa_key_usage_t)0x00004000)
+#define PSA_KEY_LIFETIME_VOLATILE ((psa_key_lifetime_t)0x00000000)
+#define PSA_ALG_ECDH ((psa_algorithm_t)0x09020000)
+
+#define PSA_SUCCESS ((psa_status_t)0)
+#define PSA_ERROR_INVALID_HANDLE ((psa_status_t)-136)
+#define PSA_ERROR_BAD_STATE ((psa_status_t)-137)
+
+psa_status_t psa_crypto_init(void);
+psa_status_t psa_destroy_key(mbedtls_svc_key_id_t key);
+void psa_set_key_usage_flags(psa_key_attributes_t *attributes, psa_key_usage_t usage_flags);
+void psa_set_key_lifetime(psa_key_attributes_t *attributes, psa_key_lifetime_t lifetime);
+void psa_set_key_algorithm(psa_key_attributes_t *attributes, psa_algorithm_t alg);
+void psa_set_key_type(psa_key_attributes_t *attributes, psa_key_type_t type);
+void psa_set_key_bits(psa_key_attributes_t *attributes, size_t bits);
+psa_status_t psa_generate_key(const psa_key_attributes_t *attributes, mbedtls_svc_key_id_t *key);
+psa_status_t psa_export_public_key(mbedtls_svc_key_id_t key, uint8_t *data, size_t data_size,
+				   size_t *data_length);
+psa_status_t psa_raw_key_agreement(psa_algorithm_t alg, mbedtls_svc_key_id_t private_key,
+				   const uint8_t *peer_key, size_t peer_key_length,
+				   uint8_t *output, size_t output_size, size_t *output_length);
+psa_status_t psa_generate_random(uint8_t *output, size_t output_size);
+
+#endif /* PSA_CRYPTO_FOR_MOCKING_H__ */

tests/unit/lib/bluetooth/peer_manager/prj.conf

@@ -0,0 +1,10 @@
+CONFIG_UNITY=y
+
+# Enable generation of new LESC key pair after every pairing attempt
+# CONFIG_PM_LESC_GENERATE_NEW_KEYS=y
+
+# Repeated Attempts Protection feature
+CONFIG_PM_RA_PROTECTION=y
+
+# Include sec delay code
+CONFIG_PM_HANDLER_SEC_DELAY_MS=100