fs: bm_zms: correct error check for ring_buf_get()

eivindj-nordic · eivindj-nordic · commit efb4e745aa1f · 2025-11-06T10:18:57.000+01:00
ring_buf_get() returns the size retrieved and will never be negative.

Signed-off-by: Eivind Jølsgard &lt;eivind.jolsgard@nordicsemi.no&gt;
diff --git a/subsys/fs/bm_zms/bm_zms.c b/subsys/fs/bm_zms/bm_zms.c
@@ -138,7 +138,7 @@ static void queue_process(void)
 			NRFX_CRITICAL_SECTION_ENTER();
 			rc = ring_buf_get(&zms_fifo, (uint8_t *)&cur_op, sizeof(zms_op_t));
 			NRFX_CRITICAL_SECTION_EXIT();
-			if (rc < 0) {
+			if (rc != sizeof(zms_op_t)) {
 				result = -EIO;
 				goto completed;
 			}

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ static void queue_process(void)`
`138`	`138`	`NRFX_CRITICAL_SECTION_ENTER();`
`139`	`139`	`rc = ring_buf_get(&zms_fifo, (uint8_t *)&cur_op, sizeof(zms_op_t));`
`140`	`140`	`NRFX_CRITICAL_SECTION_EXIT();`
`141`		`- if (rc < 0) {`
	`141`	`+ if (rc != sizeof(zms_op_t)) {`
`142`	`142`	`result = -EIO;`
`143`	`143`	`goto completed;`
`144`	`144`	`}`