Unit test Kconfig cleanup #519
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog-entry-required
|
You can find the documentation preview for this PR here. |
eivindj-nordic
force-pushed
the
unit_test_kconfig_cleanup
branch
from
9522f44 to
3eea0ce
Compare
eivindj-nordic
removed
the
changelog-entry-required
Contributor
Author
|
Touching tests only, no changelog required. |
tejlmand
approved these changes
Nov 27, 2025
eivindj-nordic
force-pushed
the
unit_test_kconfig_cleanup
branch
from
3eea0ce to
2f119f9
Compare
github-actions
bot
added
the
changelog-entry-required
eivindj-nordic
removed
the
changelog-entry-required
marenges
approved these changes
Nov 28, 2025
lemrey
reviewed
Nov 28, 2025
| ) | ||
|
|
||
| target_include_directories(app PRIVATE | ||
| zephyr_include_directories(app PRIVAT |
Contributor
Author
There was a problem hiding this comment.
This should actually be removed.
tests/lib/bluetooth/ble_qwr/Kconfig
Outdated
Comment on lines
1
to
2
| # Clear dependencies for BLE_QWR and enable it to allow | ||
| # testing the features without enabling the library. |
Contributor
There was a problem hiding this comment.
This wording could be improved, what about
Redefine this symbol without dependencies, so that tests
can enable it without having to enable the dependencies too
| config BLE_BAS | ||
| default y | ||
|
|
||
| # Redefine Kconfigs used by the tested module that is defined in |
eivindj-nordic
force-pushed
the
unit_test_kconfig_cleanup
branch
from
2f119f9 to
dbf6b07
Compare
github-actions
bot
added
the
changelog-entry-required
eivindj-nordic
removed
the
changelog-entry-required
eivindj-nordic
force-pushed
the
unit_test_kconfig_cleanup
branch
from
dbf6b07 to
09738d5
Compare
github-actions
bot
added
the
changelog-entry-required
Use Kconfig to enable modules under test and some cleanup. Signed-off-by: Eivind Jølsgard <[email protected]>
eivindj-nordic
force-pushed
the
unit_test_kconfig_cleanup
branch
from
09738d5 to
3e8e657
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Kconfig to enable modules under test and some cleanup.