snippets: nrf93m1dk: Add snippet for enabling modem-bypass in nRF93M1DK #119090
SeppoTakalocompliance.yml
on: pull_request
Run compliance checks on patch series (PR)
2m 40s
Annotations
8 errors and 1 warning
|
Run compliance checks on patch series (PR)
Process completed with exit code 1.
|
|
Run compliance checks on patch series (PR):
DevicetreeLinting.txt#L0
See https://docs.zephyrproject.org/latest/contribute/style/devicetree.html for more details.
Not correctly formatted.:Index: a/snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay
===================================================================
--- a/snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay
+++ a/snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay
@@ -8,10 +8,8 @@
* This overlay is used to enable the nRF93M1DK in a modem-bypass mode where
* modem is powered on a boot and UART switch is controlled to route the
* modem's main UART to the VCOM1 port on the on-board debugger.
*/
-
-
/*
* UART routing switch:
* control IO have a pull-down resistor that defaults to bypass mode, so delete the control GPIO
*/
@@ -23,9 +21,8 @@
&modem {
status = "okay";
};
-
/*
* Activate POWERKEY:
* Driver powerkey on boot, so the modem boots when DC power is enabled
*/
@@ -39,9 +36,8 @@
output-high;
};
};
-
/*
* Modem DCDC control:
* When board boots, wait 500ms before enabling the power for modem.
* Then wait another 500ms while the powerkey is active to trigger modem boot up.
@@ -50,9 +46,8 @@
off-on-delay-us = <500000>;
startup-delay-us = <500000>;
};
-
/*
* Release powerkey:
* After modem is booted up, release the powerkey.
*/
File:snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay
:Remove unnecessary new lines. Expecting 1.
File:snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay
Line:11
Column:3
EndLine:14
:Remove unnecessary new lines. Expecting 2.
File:snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay
Line:25
Column:2
EndLine:28
:Remove unnecessary new lines. Expecting 2.
File:snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay
Line:41
Column:2
EndLine:44
:Remove unnecessary new lines. Expecting 2.
File:snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay
Line:52
Column:2
EndLine:55
|
|
Run compliance checks on patch series (PR)
Process completed with exit code 1.
|
|
Run compliance checks on patch series (PR):
snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay#L52
snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay:52 Remove unnecessary new lines. Expecting 2.
See https://docs.zephyrproject.org/latest/contribute/style/devicetree.html for more details.
|
|
Run compliance checks on patch series (PR):
snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay#L41
snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay:41 Remove unnecessary new lines. Expecting 2.
See https://docs.zephyrproject.org/latest/contribute/style/devicetree.html for more details.
|
|
Run compliance checks on patch series (PR):
snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay#L25
snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay:25 Remove unnecessary new lines. Expecting 2.
See https://docs.zephyrproject.org/latest/contribute/style/devicetree.html for more details.
|
|
Run compliance checks on patch series (PR):
snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay#L11
snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay:11 Remove unnecessary new lines. Expecting 1.
See https://docs.zephyrproject.org/latest/contribute/style/devicetree.html for more details.
|
|
Not correctly formatted.:
snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay#L0
snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay Index: a/snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay
===================================================================
--- a/snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay
+++ a/snippets/nrf93m1dk-modem-bypass/nrf93m1dk_modem_bypas.overlay
@@ -8,10 +8,8 @@
* This overlay is used to enable the nRF93M1DK in a modem-bypass mode where
* modem is powered on a boot and UART switch is controlled to route the
* modem's main UART to the VCOM1 port on the on-board debugger.
*/
-
-
/*
* UART routing switch:
* control IO have a pull-down resistor that defaults to bypass mode, so delete the control GPIO
*/
@@ -23,9 +21,8 @@
&modem {
status = "okay";
};
-
/*
* Activate POWERKEY:
* Driver powerkey on boot, so the modem boots when DC power is enabled
*/
@@ -39,9 +36,8 @@
output-high;
};
};
-
/*
* Modem DCDC control:
* When board boots, wait 500ms before enabling the power for modem.
* Then wait another 500ms while the powerkey is active to trigger modem boot up.
@@ -50,9 +46,8 @@
off-on-delay-us = <500000>;
startup-delay-us = <500000>;
};
-
/*
* Release powerkey:
* After modem is booted up, release the powerkey.
*/
See https://docs.zephyrproject.org/latest/contribute/style/devicetree.html for more details.
|
|
Run compliance checks on patch series (PR)
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@d4323d4df104b026a6aa633fdb11d772146be0bf, actions/checkout@v4, actions/upload-artifact@4cec3d8aa04e39d1a68397de0c4cd6fb9dce8ec1. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
compliance.xml
|
1.34 KB |
sha256:1a76480317b8040f2914db4daac9335a814450cad737a7aca9941d2e0ca10f53
|
|