Skip to content

Commit 454d5f1

Browse files
committed
nrf_security: stop using MBEDTLS_CONFIG_FILE for PSA Crypto
It's now only used for Mbed TLS itself, not TF-PSA-Crypto, so stop generating/feeding the file in those cases and guard the Kconfig option behind CONFIG_MBEDTLS (configdefault didn't work). Signed-off-by: Tomi Fontanilles <tomi.fontanilles@nordicsemi.no>
1 parent 32c7e84 commit 454d5f1

4 files changed

Lines changed: 3 additions & 6 deletions

File tree

modules/trusted-firmware-m/tfm_boards/external_core.cmake

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ if(TARGET psa_crypto_config)
5656
set(EXTERNAL_CRYPTO_CORE_HANDLED_PSA_CRYPTO_CONFIG True)
5757
target_compile_definitions(psa_crypto_config
5858
INTERFACE
59-
MBEDTLS_CONFIG_FILE="${CONFIG_MBEDTLS_CONFIG_FILE}"
6059
TF_PSA_CRYPTO_CONFIG_FILE="${CONFIG_TF_PSA_CRYPTO_CONFIG_FILE}"
6160
# Give a signal that we are inside TF-M build to prevent check_config.h
6261
# complaining about lacking legacy features for Mbed TLS wrapper APIs, TLS/DTLS and X.509.
@@ -77,7 +76,6 @@ if(TARGET psa_crypto_library_config)
7776
set(EXTERNAL_CRYPTO_CORE_HANDLED_PSA_CRYPTO_LIBRARY_CONFIG True)
7877
target_compile_definitions(psa_crypto_library_config
7978
INTERFACE
80-
MBEDTLS_CONFIG_FILE="${CONFIG_MBEDTLS_CONFIG_FILE}"
8179
TF_PSA_CRYPTO_CONFIG_FILE="${CONFIG_TF_PSA_CRYPTO_CONFIG_FILE}"
8280
TF_PSA_CRYPTO_USER_CONFIG_FILE="${CONFIG_TF_PSA_CRYPTO_USER_CONFIG_FILE}"
8381
)
@@ -119,7 +117,6 @@ if(TARGET tfm_sprt)
119117
set(EXTERNAL_CRYPTO_CORE_HANDLED_TFM_SPRT True)
120118
target_compile_definitions(tfm_sprt
121119
PRIVATE
122-
MBEDTLS_CONFIG_FILE="${CONFIG_MBEDTLS_CONFIG_FILE}"
123120
TF_PSA_CRYPTO_CONFIG_FILE="${CONFIG_TF_PSA_CRYPTO_CONFIG_FILE}"
124121
INSIDE_TFM_BUILD
125122
)

modules/trusted-firmware-m/tfm_boards/external_core_install.cmake

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ install(
3737

3838
install(
3939
FILES
40-
${PSA_CRYPTO_CONFIG_INTERFACE_PATH}/${CONFIG_MBEDTLS_CONFIG_FILE}
4140
${PSA_CRYPTO_CONFIG_INTERFACE_PATH}/${CONFIG_TF_PSA_CRYPTO_CONFIG_FILE}
4241
DESTINATION
4342
${INSTALL_INTERFACE_INC_DIR}/

subsys/nrf_security/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -62,6 +62,7 @@ config MBEDTLS_PSA_CRYPTO_BUILTIN_KEYS
6262
Promptless option used to control if the PSA Crypto core should have support for builtin keys or not.
6363

6464
config MBEDTLS_CONFIG_FILE
65+
depends on MBEDTLS
6566
default "nrf-config.h"
6667

6768
if MBEDTLS_ENABLE_HEAP

subsys/nrf_security/cmake/generate_configs.cmake

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ macro(generate_mbedcrypto_interface_configs)
4747
# Generate MBEDCRYPTO_CONFIG_FILE
4848
if(CONFIG_MBEDTLS_LEGACY_CRYPTO_C)
4949
include(${NRF_SECURITY_DIR}/cmake/legacy_crypto_config.cmake)
50-
else()
50+
elseif(CONFIG_MBEDTLS)
5151
include(${NRF_SECURITY_DIR}/cmake/nrf_config.cmake)
5252
endif()
5353

@@ -128,7 +128,7 @@ macro(generate_mbedcrypto_library_configs)
128128
# Generate MBEDCRYPTO_CONFIG_FILE
129129
if(CONFIG_MBEDTLS_LEGACY_CRYPTO_C)
130130
include(${NRF_SECURITY_DIR}/cmake/legacy_crypto_config.cmake)
131-
else()
131+
elseif(CONFIG_MBEDTLS)
132132
include(${NRF_SECURITY_DIR}/cmake/nrf_config.cmake)
133133
endif()
134134

0 commit comments

Comments
 (0)