Skip to content

Commit 55a183c

Browse files
committed
net: Remove deprecated TLS_CREDENTIAL_SERVER_CERTIFICATE symbol usage
The symbol was deprecated in Zephyr 4.2.0 in favor of TLS_CREDENTIAL_PUBLIC_CERTIFICATE and will be removed soon, so remove any leftover usage in NCS. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
1 parent 47a362e commit 55a183c

9 files changed

Lines changed: 16 additions & 16 deletions

File tree

samples/crypto/psa_tls/src/non-secure/psa_tls_credentials_server.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@ static int tls_set_credentials_from_ps(void)
8787
}
8888

8989
int err = tls_credential_add(SERVER_CERTIFICATE_TAG,
90-
TLS_CREDENTIAL_SERVER_CERTIFICATE,
90+
TLS_CREDENTIAL_PUBLIC_CERTIFICATE,
9191
server_cert_buf, cred_len);
9292
if (err < 0) {
9393
LOG_ERR("Failed to register Server certificate from"

samples/crypto/psa_tls/src/secure/psa_tls_credentials_server.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ int tls_set_credentials(void)
2020
LOG_INF("Registering Server certificate and key");
2121

2222
int err = tls_credential_add(SERVER_CERTIFICATE_TAG,
23-
TLS_CREDENTIAL_SERVER_CERTIFICATE,
23+
TLS_CREDENTIAL_PUBLIC_CERTIFICATE,
2424
server_certificate,
2525
sizeof(server_certificate));
2626
if (err < 0) {

samples/dect/dect_shell/src/native_tls/desh_native_tls.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ enum tls_credential_type desh_cmng_to_tls_cred(enum desh_cmng_type type)
6161
case DESH_AT_CMNG_TYPE_CA_CERT:
6262
return TLS_CREDENTIAL_CA_CERTIFICATE;
6363
case DESH_AT_CMNG_TYPE_CLIENT_CERT:
64-
return TLS_CREDENTIAL_SERVER_CERTIFICATE;
64+
return TLS_CREDENTIAL_PUBLIC_CERTIFICATE;
6565
case DESH_AT_CMNG_TYPE_CLIENT_KEY:
6666
return TLS_CREDENTIAL_PRIVATE_KEY;
6767
case DESH_AT_CMNG_TYPE_PSK:

samples/net/http_server/src/credentials_provision.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ int credentials_provision(void)
5151
}
5252

5353
ret = tls_credential_add(CONFIG_HTTP_SERVER_SAMPLE_SERVER_CERTIFICATE_SEC_TAG,
54-
TLS_CREDENTIAL_SERVER_CERTIFICATE,
54+
TLS_CREDENTIAL_PUBLIC_CERTIFICATE,
5555
server_certificate,
5656
sizeof(server_certificate));
5757
if (ret == -EEXIST) {

subsys/net/lib/mqtt_helper/mqtt_helper.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,7 @@ static int certificates_provision(void)
175175

176176
if (sizeof(device_certificate) > 1) {
177177
err = tls_credential_add(CONFIG_MQTT_HELPER_SEC_TAG,
178-
TLS_CREDENTIAL_SERVER_CERTIFICATE,
178+
TLS_CREDENTIAL_PUBLIC_CERTIFICATE,
179179
device_certificate,
180180
sizeof(device_certificate));
181181
if (err == -EEXIST) {
@@ -221,7 +221,7 @@ static int certificates_provision(void)
221221

222222
if (sizeof(device_certificate_2) > 1) {
223223
err = tls_credential_add(CONFIG_MQTT_HELPER_SECONDARY_SEC_TAG,
224-
TLS_CREDENTIAL_SERVER_CERTIFICATE,
224+
TLS_CREDENTIAL_PUBLIC_CERTIFICATE,
225225
device_certificate_2,
226226
sizeof(device_certificate_2));
227227
if (err == -EEXIST) {

subsys/net/lib/nrf_cloud/common/src/nrf_cloud_credentials.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ static int cred_type[CRED_COUNT] = {
2525
MODEM_KEY_MGMT_CRED_TYPE_CA_CHAIN, MODEM_KEY_MGMT_CRED_TYPE_PUBLIC_CERT,
2626
MODEM_KEY_MGMT_CRED_TYPE_PRIVATE_CERT
2727
#else
28-
TLS_CREDENTIAL_CA_CERTIFICATE, TLS_CREDENTIAL_SERVER_CERTIFICATE, TLS_CREDENTIAL_PRIVATE_KEY
28+
TLS_CREDENTIAL_CA_CERTIFICATE, TLS_CREDENTIAL_PUBLIC_CERTIFICATE, TLS_CREDENTIAL_PRIVATE_KEY
2929
#endif
3030
};
3131

subsys/net/lib/softap_wifi_provision/softap_wifi_provision.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -520,7 +520,7 @@ static int certificate_register(void)
520520
}
521521

522522
ret = tls_credential_add(CONFIG_SOFTAP_WIFI_PROVISION_CERTIFICATE_SEC_TAG,
523-
TLS_CREDENTIAL_SERVER_CERTIFICATE,
523+
TLS_CREDENTIAL_PUBLIC_CERTIFICATE,
524524
server_certificate,
525525
sizeof(server_certificate));
526526
if (ret == -EEXIST) {

subsys/net/lib/tls_credentials/tls_credentials_nrf_modem.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ static enum modem_key_mgmt_cred_type modem_key_mgmt_type_get(enum tls_credential
7777
switch (type) {
7878
case TLS_CREDENTIAL_CA_CERTIFICATE:
7979
return MODEM_KEY_MGMT_CRED_TYPE_CA_CHAIN;
80-
case TLS_CREDENTIAL_SERVER_CERTIFICATE:
80+
case TLS_CREDENTIAL_PUBLIC_CERTIFICATE:
8181
return MODEM_KEY_MGMT_CRED_TYPE_PUBLIC_CERT;
8282
case TLS_CREDENTIAL_PRIVATE_KEY:
8383
return MODEM_KEY_MGMT_CRED_TYPE_PRIVATE_CERT;
@@ -92,7 +92,7 @@ static enum tls_credential_type tls_credential_type_get(enum modem_key_mgmt_cred
9292
case MODEM_KEY_MGMT_CRED_TYPE_CA_CHAIN:
9393
return TLS_CREDENTIAL_CA_CERTIFICATE;
9494
case MODEM_KEY_MGMT_CRED_TYPE_PUBLIC_CERT:
95-
return TLS_CREDENTIAL_SERVER_CERTIFICATE;
95+
return TLS_CREDENTIAL_PUBLIC_CERTIFICATE;
9696
case MODEM_KEY_MGMT_CRED_TYPE_PRIVATE_CERT:
9797
return TLS_CREDENTIAL_PRIVATE_KEY;
9898
default:

tests/subsys/net/lib/tls_credentials_nrf_modem/main.c

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,11 +46,11 @@ ZTEST(tls_credentials, test_00_init_import_list_public_api)
4646
/* The server certificate and private key cannot be accessed, instead returning EACCESS. */
4747
modem_key_mgmt_read_fake.return_val = -EACCES;
4848

49-
zassert_equal(tls_credential_get(1, TLS_CREDENTIAL_SERVER_CERTIFICATE, cred, &len),
49+
zassert_equal(tls_credential_get(1, TLS_CREDENTIAL_PUBLIC_CERTIFICATE, cred, &len),
5050
-EACCES);
5151
zassert_equal(tls_credential_get(1, TLS_CREDENTIAL_PRIVATE_KEY, cred, &len), -EACCES);
5252

53-
zassert_equal(tls_credential_get(2, TLS_CREDENTIAL_SERVER_CERTIFICATE, cred, &len),
53+
zassert_equal(tls_credential_get(2, TLS_CREDENTIAL_PUBLIC_CERTIFICATE, cred, &len),
5454
-EACCES);
5555
zassert_equal(tls_credential_get(2, TLS_CREDENTIAL_PRIVATE_KEY, cred, &len), -EACCES);
5656
}
@@ -61,10 +61,10 @@ ZTEST(tls_credentials, test_00_init_import_list_internal_api)
6161
zassert_not_null(credential_get(101, TLS_CREDENTIAL_CA_CERTIFICATE));
6262
zassert_not_null(credential_get(103, TLS_CREDENTIAL_CA_CERTIFICATE));
6363

64-
zassert_not_null(credential_get(1, TLS_CREDENTIAL_SERVER_CERTIFICATE));
64+
zassert_not_null(credential_get(1, TLS_CREDENTIAL_PUBLIC_CERTIFICATE));
6565
zassert_not_null(credential_get(1, TLS_CREDENTIAL_PRIVATE_KEY));
6666

67-
zassert_not_null(credential_get(2, TLS_CREDENTIAL_SERVER_CERTIFICATE));
67+
zassert_not_null(credential_get(2, TLS_CREDENTIAL_PUBLIC_CERTIFICATE));
6868
zassert_not_null(credential_get(2, TLS_CREDENTIAL_PRIVATE_KEY));
6969
}
7070

@@ -94,7 +94,7 @@ ZTEST(tls_credentials, test_00_init_import_list_internal_api_iterator)
9494
cred = credential_next_get(1, NULL);
9595
zassert_not_null(cred);
9696
zassert_equal(cred->tag, 1);
97-
zassert_equal(cred->type, TLS_CREDENTIAL_SERVER_CERTIFICATE);
97+
zassert_equal(cred->type, TLS_CREDENTIAL_PUBLIC_CERTIFICATE);
9898
cred = credential_next_get(1, cred);
9999
zassert_not_null(cred);
100100
zassert_equal(cred->tag, 1);
@@ -108,7 +108,7 @@ ZTEST(tls_credentials, test_00_init_import_list_internal_api_iterator)
108108
cred = credential_next_get(2, cred);
109109
zassert_not_null(cred);
110110
zassert_equal(cred->tag, 2);
111-
zassert_equal(cred->type, TLS_CREDENTIAL_SERVER_CERTIFICATE);
111+
zassert_equal(cred->type, TLS_CREDENTIAL_PUBLIC_CERTIFICATE);
112112
}
113113

114114
/* base64(bin("B9BAC15641653CAE2B5151DCBD0C40DDCDF19125950FA2475977437EA35F7A45")) */

0 commit comments

Comments
 (0)