samples: matter: Fix Matter Bridge nullpointer failures

- Added check if the bridged device exists while getting its
provider.
- Properly unregistered Identify Cluster for the bridged device.

Signed-off-by: Arkadiusz Balys <[email protected]>

Author: ArekBalysNordic

applications/matter_bridge/src/core/bridge_manager.cpp

@@ -503,8 +503,10 @@ BridgedDeviceDataProvider *BridgeManager::GetProvider(EndpointId endpoint, uint1
 	uint16_t endpointIndex = emberAfGetDynamicIndexFromEndpoint(endpoint);
 	if (Instance().mDevicesMap.Contains(endpointIndex)) {
 		BridgedDevicePair &bridgedDevices = Instance().mDevicesMap[endpointIndex];
-		deviceType = bridgedDevices.mDevice->GetDeviceType();
-		return bridgedDevices.mProvider;
+		if (bridgedDevices.mDevice) {
+			deviceType = bridgedDevices.mDevice->GetDeviceType();
+			return bridgedDevices.mProvider;
+		}
 	}
 	return nullptr;
 }

applications/matter_bridge/src/core/matter_bridged_device.h

@@ -110,12 +110,16 @@ class MatterBridgedDevice {
 			memcpy(mNodeLabel, nodeLabel, strnlen(nodeLabel, Nrf::MatterBridgedDevice::kNodeLabelSize));
 		}
 	}
-	virtual ~MatterBridgedDevice() {
+	virtual ~MatterBridgedDevice()
+	{
 		if (mIdentifyCluster.IsConstructed()) {
+			chip::app::CodegenDataModelProvider::Instance().Registry().Unregister(
+				&mIdentifyCluster.Cluster());
 			mIdentifyCluster.Destroy();
 		}
 
-		chip::Platform::MemoryFree(mDataVersion); }
+		chip::Platform::MemoryFree(mDataVersion);
+	}
 
 	void Init(chip::EndpointId endpoint)
 	{