samples: bluetooth: direct_test_mode: fix CTE TX bug

1. Fixed a bug where DTM sample returns COMMAND DISALLOWED
error when CTE is used.
The Bluetooth Core Specification mandates returning
COMMAND DISALLOWED when:
`CTE_Length is not zero and PHY specifies
a PHY that does not allow Constant Tone Extensions`
In other words, the commands should be disallowed when
coded PHY is used, because Coded PHY doesn't allow CTE.

2. Fixed an invalid content of CTE PDU
3. Fixed a bug when dtm_setup_set_antenna_params() would
call when CTE TX is used

Signed-off-by: Ivan Iushkov <ivan.iushkov@nordicsemi.no>

Author: ivaniushkov

samples/bluetooth/direct_test_mode/src/dtm.c

@@ -2163,23 +2163,25 @@ int dtm_setup_set_cte_mode(enum dtm_cte_type type, uint8_t time)
 	switch (type) {
 	case DTM_CTE_TYPE_AOA:
 		dtm_inst.cte_info.mode = DTM_CTE_MODE_AOA;
+		cte_info |= ((0 & CTEINFO_TYPE_MASK) << CTEINFO_TYPE_POS);
 		break;
 
 	case DTM_CTE_TYPE_AOD_1US:
 		dtm_inst.cte_info.mode = DTM_CTE_MODE_AOD;
 		dtm_inst.cte_info.slot = DTM_CTE_SLOT_1US;
+		cte_info |= ((1 & CTEINFO_TYPE_MASK) << CTEINFO_TYPE_POS);
 		break;
 
 	case DTM_CTE_TYPE_AOD_2US:
 		dtm_inst.cte_info.mode = DTM_CTE_MODE_AOD;
 		dtm_inst.cte_info.slot = DTM_CTE_SLOT_2US;
+		cte_info |= ((2 & CTEINFO_TYPE_MASK) << CTEINFO_TYPE_POS);
 		break;
 
 	default:
 		return -EINVAL;
 	}
 
-	cte_info |= ((dtm_inst.cte_info.mode & CTEINFO_TYPE_MASK) << CTEINFO_TYPE_POS);
 	dtm_inst.cte_info.info = cte_info;
 
 	return 0;

samples/bluetooth/direct_test_mode/src/transport/dtm_hci.c

@@ -171,8 +171,7 @@ static int cte_set(uint8_t cte_len, uint8_t cte_type,
 
 	switch (cte_type) {
 	case BT_HCI_LE_AOA_CTE:
-		err = dtm_setup_set_cte_mode(DTM_CTE_TYPE_AOA, cte_len);
-		break;
+		return dtm_setup_set_cte_mode(DTM_CTE_TYPE_AOA, cte_len);
 
 	case BT_HCI_LE_AOD_CTE_1US:
 		err = dtm_setup_set_cte_mode(DTM_CTE_TYPE_AOD_1US, cte_len);
@@ -624,7 +623,7 @@ static int hci_tx_test(uint16_t opcode, const uint8_t *data)
 	}
 
 	if ((cte_len != 0) &&
-		(phy != BT_HCI_LE_TX_PHY_CODED_S8) && (phy != BT_HCI_LE_TX_PHY_CODED_S2)) {
+		((phy == BT_HCI_LE_TX_PHY_CODED_S8) || (phy == BT_HCI_LE_TX_PHY_CODED_S2))) {
 		return base_cc_evt(opcode, BT_HCI_ERR_CMD_DISALLOWED);
 	}