ci,kconfig: fix NCS 3.3 compliance failures

Install zephyr/scripts/requirements-compliance.txt before running
compliance (NCS 3.3 check_compliance.py requires python-dotenv, reuse,
and other packages not present by default).

Fix KconfigBasic failures introduced by NCS 3.3 check_compliance.py:
- Remove "Enable"/"Enables" prefix from boolean Kconfig prompts across
  Kconfig, utils/tlv/Kconfig, utils/settings_utils/Kconfig,
  samples/sid_end_device/Kconfig, and tests/unit_tests/mfg_parsers/Kconfig
- Replace deprecated per-instance NRFX_SPI0/1/2 selects with NRFX_SPI
  (per-instance symbols were removed in NCS 3.3 hal_nordic)

Signed-off-by: Krzysztof Taborowski <krzysztof.taborowski@nordicsemi.no>

Author: ktaborowski

.github/workflows/validate_code_style.yml

@@ -64,6 +64,10 @@ jobs:
           west init -l sidewalk --mf west.yml &&
           west update -n -o=--depth=1 --path-cache /workdir/
 
+      - name: Install compliance requirements
+        run: |
+          pip3 install -r zephyr/scripts/requirements-compliance.txt
+
       - name: Run Compliance Tests
         run: |
           source zephyr/zephyr-env.sh

Kconfig

@@ -5,7 +5,7 @@
 #
 
 menuconfig SIDEWALK
-	bool "Enable Amazon Sidewalk"
+	bool "Amazon Sidewalk support"
 	imply SIDEWALK_DFU
 
 if SIDEWALK
@@ -17,7 +17,7 @@ config MAIN_STACK_SIZE
 DT_CHOSEN_Z_LORA_TRANSCEIVER := zephyr,lora-transceiver
 
 config SIDEWALK_SUBGHZ_SUPPORT
-	bool "Enable Sub-GHz link type support in Sidewalk libraries"
+	bool "Sub-GHz link type support in Sidewalk libraries"
 	default y if $(dt_chosen_enabled,$(DT_CHOSEN_Z_LORA_TRANSCEIVER))
 	help
 	  Use Sidewalk with support for BLE, LoRa and FSK.
@@ -137,7 +137,7 @@ module-str = Sidewalk spi bus interface
 source "${ZEPHYR_BASE}/subsys/logging/Kconfig.template.log_config"
 
 config DEPRECATED_SIDEWALK_PAL_INIT
-	bool "Enable Sidewalk platform init module  [DEPRICATED]"
+	bool "Sidewalk platform init module [DEPRECATED]"
 	help
 	  Sidewalk 1.16 stack introduces new sid api sid_platform_init.
 	  Now new api togehter with sid_common pal are used by default.
@@ -169,27 +169,27 @@ config SIDEWALK_BLE_ADV_INT_TRANSITION
 	default 30
 
 config SIDEWALK_VENDOR_SERVICE
-	bool "Enable Sidewalk BLE vendor service"
+	bool "Sidewalk BLE vendor service"
 
 config SIDEWALK_LOGGING_SERVICE
-	bool "Enable Sidewalk BLE logging service"
+	bool "Sidewalk BLE logging service"
 
 config SIDEWALK_DEMO_PARSER
-	bool "Enable sensor monitoring demo parser module"
+	bool "Sensor monitoring demo parser module"
 
 config SIDEWALK_ON_DEV_CERT
-	bool "Enable Sidewalk on device certification"
+	bool "Sidewalk on device certification"
 	depends on SHELL
 
 config DEPRECATED_SIDEWALK_MFG_STORAGE
-	bool "Enable previous implementation of manufacturing module [DEPREACATED]"
+	bool "Previous implementation of manufacturing module [DEPRECATED]"
 	imply FLASH
 	help
 	  Previous Sidewalk manufacturing storage module
 	  This implementation is DEPRECATED.
 
 config SIDEWALK_MFG_STORAGE_SUPPORT_HEX_v7
-	bool "Enable support for old Sidewalk manufaturing hex format"
+	bool "Support for old Sidewalk manufacturing hex format"
 	default y
 	depends on SIDEWALK_MFG_STORAGE
 	help
@@ -198,7 +198,7 @@ config SIDEWALK_MFG_STORAGE_SUPPORT_HEX_v7
 	  and will be supported after enabling this configuration.
 
 config SIDEWALK_CRYPTO_PSA_KEY_STORAGE
-	bool "Enable psa crypto storage for persistent Sidewalk keys [EXPERIMENTAL]"
+	bool "PSA crypto storage for persistent Sidewalk keys [EXPERIMENTAL]"
 	default SIDEWALK
 	select EXPERIMENTAL
 	help
@@ -225,15 +225,15 @@ choice SIDEWALK_NRFX_SPI_INSTANCE_ID
 
 config SIDEWALK_NRFX_SPI0
 	bool "SPI0"
-	select NRFX_SPI0
+	select NRFX_SPI
 
 config SIDEWALK_NRFX_SPI1
 	bool "SPI1"
-	select NRFX_SPI1
+	select NRFX_SPI
 
 config SIDEWALK_NRFX_SPI2
 	bool "SPI2"
-	select NRFX_SPI2
+	select NRFX_SPI
 
 endchoice # SIDEWALK_NRFX_SPI_INSTANCE_ID
 

samples/sid_end_device/Kconfig

@@ -38,7 +38,7 @@ rsource "Kconfig.sensor_monitoring"
 endif #SID_END_DEVICE_SENSOR_MONITORING
 
 config SID_END_DEVICE_CLI
-    bool "Enable Sidewalk CLI (DUT)"
+    bool "Sidewalk CLI (DUT)"
     imply SHELL
     help
       Enables Sidewalk command line interface.
@@ -59,7 +59,7 @@ config SHELL_BACKEND_SERIAL_RX_RING_BUFFER_SIZE
 	default 1024
 
 config SID_END_DEVICE_CLI_ALIVE_MAKRER
-    bool "Enable alive marker"
+    bool "Alive marker"
     help
         Enable alive marker that periodically prints "alive" message to log.
         Useful to verify that application is running and not stuck.
@@ -68,14 +68,14 @@ endif # SID_END_DEVICE_CLI
 
 config SID_END_DEVICE_AUTO_START
     default y
-    bool "Enable automatic Sidewalk initlization and start"
+    bool "Automatic Sidewalk initialization and start"
 
 config SID_END_DEVICE_AUTO_CONN_REQ
     default y
-    bool "Enable automatic connection request before message send"
+    bool "Automatic connection request before message send"
 
 config SID_END_DEVICE_PERSISTENT_LINK_MASK
-    bool "Enable persitent link mask"
+    bool "Persistent link mask"
     help
       The Sidewalk link mask persists after a device reset
       but defaults after a factory reset.
@@ -87,7 +87,7 @@ config SID_END_DEVICE_EVENT_HEAP_SIZE
 
 config SIDEWALK_FILE_TRANSFER
     select EXPERIMENTAL
-    bool "Enable Sidewalk file transfer"
+    bool "Sidewalk file transfer"
     help
       Add support for Sidewalk Bulk Data Transfer (SBDT)
       in application.
@@ -134,7 +134,7 @@ config SBDT_MAX_PARALEL_TRANSFERS
 endif # SIDEWALK_FILE_TRANSFER
 
 config SIDEWALK_LOCATION_SHELL
-    bool "Enable Sidewalk Location CLI"
+    bool "Sidewalk Location CLI"
     depends on SID_END_DEVICE_CLI
     help
         Enables Sidewalk location and dult command line interface.

tests/unit_tests/mfg_parsers/Kconfig

@@ -12,7 +12,7 @@ config SIDEWALK_LOG_LEVEL
 
 
 config SIDEWALK_CRYPTO_PSA_KEY_STORAGE
-	bool "Enable psa crypto storage for persistent Sidewalk keys [EXPERIMENTAL]"
+	bool "PSA crypto storage for persistent Sidewalk keys [EXPERIMENTAL]"
 
 source "${ZEPHYR_BASE}/../sidewalk/utils/Kconfig"
 source "Kconfig.zephyr"

utils/settings_utils/Kconfig

@@ -5,7 +5,7 @@
 #
 
 menuconfig SIDEWALK_SETTINGS_UTILS
-	bool "Enables Sidewalk settings utils module"
+	bool "Sidewalk settings utils module"
 	default SIDEWALK
 	help
 		Sidewalk settings utils allows samples to
@@ -20,7 +20,7 @@ config PERSISTENT_LINK_MASK_SETTINGS_KEY
 	  Key for settings to store last Sidewalk link mode in flash for next reboot
 
 config DEPRECATED_DFU_FLAG_SETTINGS_KEY
-	bool "Enable Key for settings to store DFU flag in flash for next reboot [DEPRICATED]"
+	bool "Key for settings to store DFU flag in flash for next reboot [DEPRECATED]"
 
 if DEPRECATED_DFU_FLAG_SETTINGS_KEY
 config DFU_FLAG_SETTINGS_KEY

utils/tlv/Kconfig

@@ -5,20 +5,20 @@
 #
 
 menuconfig SIDEWALK_TLV
-        bool "Enables Sidewalk TLV utils module"
+        bool "Sidewalk TLV utils module"
 	default n
 	help
 	  Sidewalk module to parse/write TLV data
 
 if SIDEWALK_TLV
 config SIDEWALK_TLV_RAM
-	bool "Enables RAM backend for TLV"
+	bool "RAM backend for TLV"
 	default n
 	help
 	  RAM backend for Sidewalk TLV module
 
 config SIDEWALK_TLV_FLASH
-	bool "Enables FLASH backend for TLV"
+	bool "FLASH backend for TLV"
 	default n
         imply FLASH
 	help