Skip to content

Fetch cellular modem fixes from upstream #15469

Fetch cellular modem fixes from upstream

Fetch cellular modem fixes from upstream #15469

Triggered via pull request May 20, 2026 13:15
Status Success
Total duration 4m 5s
Artifacts 1

compliance.yml

on: pull_request
Run compliance checks on patch series (PR)
4m 0s
Run compliance checks on patch series (PR)
Fit to window
Zoom out
Zoom in

Annotations

1 warning and 10 notices
Run compliance checks on patch series (PR): ClangFormat.txt#L0
See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details. You may want to run clang-format on this change: - enum modem_chat_script_result result, - void *user_data) + enum modem_chat_script_result result, void *user_data) File:drivers/modem/modem_cellular.c Line:310 You may want to run clang-format on this change: - File:drivers/modem/modem_cellular.c Line:328 You may want to run clang-format on this change: -{ const struct modem_cellular_config *config = data->dev->config; +{ + const struct modem_cellular_config *config = data->dev->config; File:drivers/modem/modem_cellular.c Line:836 You may want to run clang-format on this change: - enum modem_cellular_event evt) + enum modem_cellular_event evt) File:drivers/modem/modem_cellular.c Line:1484 You may want to run clang-format on this change: -MODEM_CHAT_SCRIPT_CMDS_DEFINE(nordic_nrf91_slm_init_chat_script_cmds, - MODEM_CHAT_SCRIPT_CMD_RESP("AT", ok_match), +MODEM_CHAT_SCRIPT_CMDS_DEFINE( + nordic_nrf91_slm_init_chat_script_cmds, MODEM_CHAT_SCRIPT_CMD_RESP("AT", ok_match), File:drivers/modem/vendor_modem_cellular/cellular_nordic_nrf91_slm.c Line:20 You may want to run clang-format on this change: - MODEM_CHAT_SCRIPT_CMD_RESP("", ok_match), - MODEM_CHAT_SCRIPT_CMD_RESP("AT+CIMI", cimi_match), - MODEM_CHAT_SCRIPT_CMD_RESP("", ok_match), - MODEM_CHAT_SCRIPT_CMD_RESP("AT%XSIM=0", ok_match), + MODEM_CHAT_SCRIPT_CMD_RESP("", ok_match), MODEM_CHAT_SCRIPT_CMD_RESP("AT+CIMI", cimi_match), + MODEM_CHAT_SCRIPT_CMD_RESP("", ok_match), MODEM_CHAT_SCRIPT_CMD_RESP("AT%XSIM=0", ok_match), File:drivers/modem/vendor_modem_cellular/cellular_nordic_nrf91_slm.c Line:32 You may want to run clang-format on this change: -MODEM_CHAT_SCRIPT_CMDS_DEFINE(quectel_bg9x_set_baudrate_cmds, - MODEM_CHAT_SCRIPT_CMD_RESP("ATE0", ok_match), - MODEM_CHAT_SCRIPT_CMD_RESP("AT+IPR=" - STRINGIFY(CONFIG_MODEM_CELLULAR_NEW_BAUDRATE), ok_match)); +MODEM_CHAT_SCRIPT_CMDS_DEFINE( + quectel_bg9x_set_baudrate_cmds, MODEM_CHAT_SCRIPT_CMD_RESP("ATE0", ok_match), + MODEM_CHAT_SCRIPT_CMD_RESP("AT+IPR=" STRINGIFY(CONFIG_MODEM_CELLULAR_NEW_BAUDRATE), + ok_match)); MODEM_CHAT_SCRIPT_DEFINE(quectel_bg9x_set_baudrate_chat_script, quectel_bg9x_set_baudrate_cmds, abort_matches, modem_cellular_chat_callback_handler, 1); -MODEM_CHAT_SCRIPT_CMDS_DEFINE(quectel_bg9x_init_chat_script_cmds, - MODEM_CHAT_SCRIPT_CMD_RESP("AT+CFUN=4", ok_match), +MODEM_CHAT_SCRIPT_CMDS_DEFINE( + quectel_bg9x_init_chat_script_cmds, MODEM_CHAT_SCRIPT_CMD_RESP("AT+CFUN=4", ok_match), File:drivers/modem/vendor_modem_cellular/cellular_quectel_bg9x.c Line:23 You may want to run clang-format on this change: -MODEM_CHAT_SCRIPT_DEFINE(quectel_bg9x_network_chat_script, - quectel_bg9x_network_setup_cmds, abort_matches, - modem_cellular_chat_callback_handler, 60); +MODEM_CHAT_SCRIPT_DEFINE(quectel_bg9x_network_chat_script, quectel_bg9x_network_setup_cmds, + abort_matches, modem_cellular_chat_callback_handler, 60); File:drivers/modem/vendor_modem_cellular/cellular_quectel_bg9x.c Line:51 You may want to run clang-format on this change: -#define MODEM_CELLULAR_COMMON_CHAT_MATCHES() \ - MODEM_CHAT_MATCH_DEFINE(ok_match, "OK", "", NULL); \ - MODEM_CHAT_MATCHES_DEFINE(__maybe_unused allow_match, \ - MODEM_CHAT_MATCH("OK", "", NULL), \ - MODEM_CHAT_MATCH("ERROR", "", NULL)); \ - MODEM_CHAT_MATCH_DEFINE(imei_match __maybe_unused, \ - "", "", modem_cellular_chat_on_imei); \ - MODEM_CHAT_MATCH_DEFINE(cgmm_match __maybe_unused, \ - "", "", modem_cellular_chat_on_cgmm); \ - MODEM_CHAT_MATCH_DEFINE(csq_match __maybe_unused, \ - "+CSQ: ", ",", modem_cellular_chat_on_csq); \ - MODEM_CHAT_MATCH_DEFINE(cesq_match __maybe_unused, \ - "+CESQ: ", ",", modem_cellular_chat_on_cesq); \ - MODEM_CHAT_MATCH_DEFINE(qccid_match __maybe_unused, \ - "+QCCID: ", "", modem_cellular_chat_on_iccid); \ - MODEM_CHAT_MATCH_DEFINE(i
You may want to run clang-format on this change: include/zephyr/drivers/modem/modem_cellular.h#L413
include/zephyr/drivers/modem/modem_cellular.h:413 -#define MODEM_CELLULAR_UNSOL_DEFINE(name, ...) \ - MODEM_CHAT_MATCHES_DEFINE(name##_matches, __VA_ARGS__); \ - static const struct modem_cellular_config_unsol name = { \ - .matches = name##_matches, \ - .size = ARRAY_SIZE(name##_matches), \ +#define MODEM_CELLULAR_UNSOL_DEFINE(name, ...) \ + MODEM_CHAT_MATCHES_DEFINE(name##_matches, __VA_ARGS__); \ + static const struct modem_cellular_config_unsol name = { \ + .matches = name##_matches, \ + .size = ARRAY_SIZE(name##_matches), \ See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change: include/zephyr/drivers/modem/modem_cellular.h#L394
include/zephyr/drivers/modem/modem_cellular.h:394 -#define MODEM_CELLULAR_COMMON_CHAT_MATCHES() \ - MODEM_CHAT_MATCH_DEFINE(ok_match, "OK", "", NULL); \ - MODEM_CHAT_MATCHES_DEFINE(__maybe_unused allow_match, \ - MODEM_CHAT_MATCH("OK", "", NULL), \ - MODEM_CHAT_MATCH("ERROR", "", NULL)); \ - MODEM_CHAT_MATCH_DEFINE(imei_match __maybe_unused, \ - "", "", modem_cellular_chat_on_imei); \ - MODEM_CHAT_MATCH_DEFINE(cgmm_match __maybe_unused, \ - "", "", modem_cellular_chat_on_cgmm); \ - MODEM_CHAT_MATCH_DEFINE(csq_match __maybe_unused, \ - "+CSQ: ", ",", modem_cellular_chat_on_csq); \ - MODEM_CHAT_MATCH_DEFINE(cesq_match __maybe_unused, \ - "+CESQ: ", ",", modem_cellular_chat_on_cesq); \ - MODEM_CHAT_MATCH_DEFINE(qccid_match __maybe_unused, \ - "+QCCID: ", "", modem_cellular_chat_on_iccid); \ - MODEM_CHAT_MATCH_DEFINE(iccid_match __maybe_unused, \ - "+ICCID: ", "", modem_cellular_chat_on_iccid); \ - MODEM_CHAT_MATCH_DEFINE(ccid_match __maybe_unused, \ - "+CCID: ", "", modem_cellular_chat_on_iccid); \ - MODEM_CHAT_MATCH_DEFINE(cimi_match __maybe_unused, \ - "", "", modem_cellular_chat_on_imsi); \ - MODEM_CHAT_MATCH_DEFINE(cgmi_match __maybe_unused, \ - "", "", modem_cellular_chat_on_cgmi); \ - MODEM_CHAT_MATCH_DEFINE(cgmr_match __maybe_unused, \ - "", "", modem_cellular_chat_on_cgmr); \ - MODEM_CHAT_MATCH_DEFINE(connect_match __maybe_unused, \ - "CONNECT", "", NULL); \ - MODEM_CHAT_MATCHES_DEFINE(__maybe_unused abort_matches, \ - MODEM_CHAT_MATCH("ERROR", "", NULL)); \ - MODEM_CHAT_MATCHES_DEFINE(__maybe_unused dial_abort_matches, \ - MODEM_CHAT_MATCH("ERROR", "", NULL), \ - MODEM_CHAT_MATCH("BUSY", "", NULL), \ - MODEM_CHAT_MATCH("NO ANSWER", "", NULL), \ - MODEM_CHAT_MATCH("NO CARRIER", "", NULL), \ - MODEM_CHAT_MATCH("NO DIALTONE", "", NULL)) +#define MODEM_CELLULAR_COMMON_CHAT_MATCHES() \ + MODEM_CHAT_MATCH_DEFINE(ok_match, "OK", "", NULL); \ + MODEM_CHAT_MATCHES_DEFINE(__maybe_unused allow_match, MODEM_CHAT_MATCH("OK", "", NULL), \ + MODEM_CHAT_MATCH("ERROR", "", NULL)); \ + MODEM_CHAT_MATCH_DEFINE(imei_match __maybe_unused, "", "", modem_cellular_chat_on_imei); \ + MODEM_CHAT_MATCH_DEFINE(cgmm_match __maybe_unused, "", "", modem_cellular_chat_on_cgmm); \ + MODEM_CHAT_MATCH_DEFINE(csq_match __maybe_unused, "+CSQ: ", ",", \ + modem_cellular_chat_on_csq); \ + MODEM_CHAT_MATCH_DEFINE(cesq_match __maybe_unused, "+CESQ: ", ",", \ + modem_cellular_chat_on_cesq); \ + MODEM_CHAT_MATCH_DEFINE(qccid_match __maybe_unused, "+QCCID: ", "", \ + modem_cellular_chat_on_iccid); \ + MODEM_CHAT_MATCH_DEFINE(iccid_match __maybe_unused, "+ICCID: ", "", \ + modem_cellular_chat_on_iccid); \ + MODEM_CHAT_MATCH_DEFINE(ccid_match __maybe_unused, "+CCID: ", "", \ + modem_cellular_chat_on_iccid); \ + MODEM_CHAT_MATCH_DEFINE(cimi_match __maybe_unused, "", "", modem_cellular_chat_on_imsi); \ + MODEM_CHAT_MATCH_DEFINE(cgmi_match __maybe_unused, "", "", modem_cellular_chat_on_cgmi); \ + MODEM_CHAT_MATCH_DEFINE(cgmr_match __maybe_unused, "", "", modem_cellular_chat_on_cgmr); \ + MODEM_CHAT_MATCH_DEFINE(connect_match __maybe_unused, "CONNECT", "", NULL); \ + MODEM_CHAT_MATCHES_DEFINE(__maybe_unused abort_matches, \ + MODEM_CHAT_MATCH("ERROR", "", NULL)); \ + MODEM_CHAT_MATCHES_DEFINE(
You may want to run clang-format on this change: drivers/modem/vendor_modem_cellular/cellular_quectel_bg9x.c#L51
drivers/modem/vendor_modem_cellular/cellular_quectel_bg9x.c:51 -MODEM_CHAT_SCRIPT_DEFINE(quectel_bg9x_network_chat_script, - quectel_bg9x_network_setup_cmds, abort_matches, - modem_cellular_chat_callback_handler, 60); +MODEM_CHAT_SCRIPT_DEFINE(quectel_bg9x_network_chat_script, quectel_bg9x_network_setup_cmds, + abort_matches, modem_cellular_chat_callback_handler, 60); See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change: drivers/modem/vendor_modem_cellular/cellular_quectel_bg9x.c#L23
drivers/modem/vendor_modem_cellular/cellular_quectel_bg9x.c:23 -MODEM_CHAT_SCRIPT_CMDS_DEFINE(quectel_bg9x_set_baudrate_cmds, - MODEM_CHAT_SCRIPT_CMD_RESP("ATE0", ok_match), - MODEM_CHAT_SCRIPT_CMD_RESP("AT+IPR=" - STRINGIFY(CONFIG_MODEM_CELLULAR_NEW_BAUDRATE), ok_match)); +MODEM_CHAT_SCRIPT_CMDS_DEFINE( + quectel_bg9x_set_baudrate_cmds, MODEM_CHAT_SCRIPT_CMD_RESP("ATE0", ok_match), + MODEM_CHAT_SCRIPT_CMD_RESP("AT+IPR=" STRINGIFY(CONFIG_MODEM_CELLULAR_NEW_BAUDRATE), + ok_match)); MODEM_CHAT_SCRIPT_DEFINE(quectel_bg9x_set_baudrate_chat_script, quectel_bg9x_set_baudrate_cmds, abort_matches, modem_cellular_chat_callback_handler, 1); -MODEM_CHAT_SCRIPT_CMDS_DEFINE(quectel_bg9x_init_chat_script_cmds, - MODEM_CHAT_SCRIPT_CMD_RESP("AT+CFUN=4", ok_match), +MODEM_CHAT_SCRIPT_CMDS_DEFINE( + quectel_bg9x_init_chat_script_cmds, MODEM_CHAT_SCRIPT_CMD_RESP("AT+CFUN=4", ok_match), See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change: drivers/modem/vendor_modem_cellular/cellular_nordic_nrf91_slm.c#L32
drivers/modem/vendor_modem_cellular/cellular_nordic_nrf91_slm.c:32 - MODEM_CHAT_SCRIPT_CMD_RESP("", ok_match), - MODEM_CHAT_SCRIPT_CMD_RESP("AT+CIMI", cimi_match), - MODEM_CHAT_SCRIPT_CMD_RESP("", ok_match), - MODEM_CHAT_SCRIPT_CMD_RESP("AT%XSIM=0", ok_match), + MODEM_CHAT_SCRIPT_CMD_RESP("", ok_match), MODEM_CHAT_SCRIPT_CMD_RESP("AT+CIMI", cimi_match), + MODEM_CHAT_SCRIPT_CMD_RESP("", ok_match), MODEM_CHAT_SCRIPT_CMD_RESP("AT%XSIM=0", ok_match), See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change: drivers/modem/vendor_modem_cellular/cellular_nordic_nrf91_slm.c#L20
drivers/modem/vendor_modem_cellular/cellular_nordic_nrf91_slm.c:20 -MODEM_CHAT_SCRIPT_CMDS_DEFINE(nordic_nrf91_slm_init_chat_script_cmds, - MODEM_CHAT_SCRIPT_CMD_RESP("AT", ok_match), +MODEM_CHAT_SCRIPT_CMDS_DEFINE( + nordic_nrf91_slm_init_chat_script_cmds, MODEM_CHAT_SCRIPT_CMD_RESP("AT", ok_match), See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change: drivers/modem/modem_cellular.c#L1484
drivers/modem/modem_cellular.c:1484 - enum modem_cellular_event evt) + enum modem_cellular_event evt) See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change: drivers/modem/modem_cellular.c#L836
drivers/modem/modem_cellular.c:836 -{ const struct modem_cellular_config *config = data->dev->config; +{ + const struct modem_cellular_config *config = data->dev->config; See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change: drivers/modem/modem_cellular.c#L328
drivers/modem/modem_cellular.c:328 - See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.
You may want to run clang-format on this change: drivers/modem/modem_cellular.c#L310
drivers/modem/modem_cellular.c:310 - enum modem_chat_script_result result, - void *user_data) + enum modem_chat_script_result result, void *user_data) See https://docs.zephyrproject.org/latest/contribute/guidelines.html#clang-format for more details.

Artifacts

Produced during runtime
Name Size Digest
compliance.xml
3.18 KB
sha256:524fb1cf3163953d852febfb34fe61f95fdbf3f1ed171e47dd58eefc4148d9d4